Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Having hist functionalities such as a chisq/ndo, KS test etc. #500

Open
garvitaa opened this issue Jun 7, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@garvitaa
Copy link

garvitaa commented Jun 7, 2023

Describe the problem, if any, that your feature request is related to

I would like to compare the shapes of two hists created using coffea by using KS test and chisq/ndof test.
But the scipy implementation available is not

Describe the feature you'd like

It would be helpful to have something similar to:

KolmogorovTest(hist1, hist2)

with options for using Under/Overflow, comparison of normalization etc, and similarly

Chi2Test(hist1, hist2)

Describe alternatives, if any, you've considered
Tried the scipy.stat.ks_2samp and scipy.stat.chisquare, but they do not work out of the box for histograms.

@garvitaa garvitaa added the enhancement New feature or request label Jun 7, 2023
@garvitaa garvitaa changed the title [FEATURE] Having hist functionalities such as a chisq/ndof and KS test etc. [FEATURE] Having hist functionalities such as a chisq/ndo, KS test etc. Jun 7, 2023
@ikrommyd
Copy link

ikrommyd commented Jun 7, 2023

Hi @henryiii, I think I would like to take a shot at this. I'm thinking of methods of hist.Hist objects to do one sample tests of the histogram vs a known distribution and methods to do two sample tests vs other hist.Hist objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants