Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] plot_ratio() to support Weighted histograms #463

Open
andreypz opened this issue Nov 4, 2022 · 1 comment
Open

[FEATURE] plot_ratio() to support Weighted histograms #463

andreypz opened this issue Nov 4, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@andreypz
Copy link

andreypz commented Nov 4, 2022

Describe the problem, if any, that your feature request is related to
I believe the current plot_ratio() method does not take into account weights of the histograms when calculating the errors.

Describe the feature you'd like

Propagate errors correctly into the ratio uncertainty, taking into account the weights

Describe alternatives, if any, you've considered

Using coffea.hist.plotratio instead

@heatherrussell
Copy link

Hi, I just encountered this - can a warning at least be added to the documentation that says that weights will be ignored in the calculation of the ratio? It's not obvious at all that they are ignored and this could easily lead to / have already led to incorrect conclusions/analyses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants