Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weight fill on integer storage #289

Open
henryiii opened this issue Dec 17, 2019 · 0 comments
Open

Weight fill on integer storage #289

henryiii opened this issue Dec 17, 2019 · 0 comments
Labels
project idea Could be a fellow project

Comments

@henryiii
Copy link
Member

henryiii commented Dec 17, 2019 •
edited

The weight= keyword argument for integer storages (Int64(), AtomicInt64()) currently accepts both integers and doubles, silently converting to integers; it should only accept integers, and provide an error if a floating type is used.

Unlimited does the correct thing and converts its internal storage to double, so that one is fine.
@henryiii henryiii mentioned this issue Dec 17, 2019
Draft
@henryiii henryiii added this to the 0.7.0 milestone Jan 8, 2020
@henryiii henryiii modified the milestones: 0.7.0, 0.8.0 Mar 11, 2020
This was referenced Mar 28, 2020
Closed
Closed
Closed
@henryiii henryiii modified the milestones: 0.8.0, 1.0.0 Jul 2, 2020
@henryiii henryiii modified the milestones: 1.0.0, 0.13.0, 1.1.0 Feb 9, 2021
@henryiii henryiii modified the milestones: 1.1.0, 1.2.0 Jul 7, 2021
@henryiii henryiii removed this from the 1.3.0 milestone Apr 15, 2022
@henryiii henryiii added the project idea Could be a fellow project label Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project idea Could be a fellow project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henryiii