Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font-awesome icons broken on staging #1501

Closed
jrochkind opened this issue Dec 6, 2021 · 1 comment
Closed

font-awesome icons broken on staging #1501

jrochkind opened this issue Dec 6, 2021 · 1 comment

Comments

@jrochkind
Copy link
Contributor

jrochkind commented Dec 6, 2021 •
edited

Eg
Screen Shot 2021-12-06 at 12 55 07 PM

It does not appear broken on production; why just staging? We use cloudfront in both....but is it's caching somehow saving us in prod but not staging? Maybe, although not immediately apparent how.

But this makes me worried that it could break in production at any time too.

Looking at what's changed to break it... it looks like upgrading sprockets-rails may be implicated?

Still investigating. But this is fairly high priority.
@jrochkind
Copy link
Contributor Author

OK, I deployed master branch to prod, and indeed icons broke on prod now.

I can fix it by locking sprockets-rails to 3.2.2.

I have filed an issue at rails/sprockets-rails#488

@jrochkind jrochkind mentioned this issue Dec 6, 2021
Merged
jrochkind added a commit that referenced this issue Dec 13, 2021
@jrochkind
update sprockets-rails, require 3.4.2
ea2cd96 
A bug in sprockets-rails made us lock to old sprockets at #1501

Bug is fixed in sprockets-rails 3.4.2, upgrade to that now.
@jrochkind jrochkind mentioned this issue Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrochkind