Verify the source on download #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammernico
force-pushed
the
verify-on-download
branch
from
a875bcf
to
51b6353
Compare
primeos-work
requested changes
May 23, 2024
There was a problem hiding this comment.
I don't understand this based on the diff. The commit message should also (at least briefly) explain this.
I assume this is about the checksum/hash verification of the source download? If so we should definitely automatically verify it but errors should be propagated and IMO we should even delete the file if the checksum didn't match (can be a bit inconvenient sometimes but makes sense for security reasons).
src/commands/source/download.rs
Outdated
Comment on lines
318
to
319
| let verify_result = super::verify(matches, config, repo, progressbars).await; | ||
| debug!("verify_result = {:?}", verify_result); |
There was a problem hiding this comment.
Does this do anything? Looks like it only adds debug output (assuming verify hopefully doesn't panic).
christophprokop
approved these changes
May 28, 2024
Fixes science-computing#371 Signed-off-by: Nico Steinle <nico.steinle@eviden.com>
ammernico
force-pushed
the
verify-on-download
branch
from
51b6353
to
e78060b
Compare
christophprokop
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371