Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify generic type naming #253

Closed
GoranSiska opened this issue Apr 1, 2016 · 3 comments
Closed

Unify generic type naming #253

GoranSiska opened this issue Apr 1, 2016 · 3 comments

Comments

@GoranSiska
Copy link

The name of generic parameters differ in interface and implementation.
IDatabaseQuery.cs Line 55 :
Page<TRet> Page<TRet>(Type[] types, Delegate cb, long page, long itemsPerPage, string sql, params object[] args);

Database.cs Line 989 :
public Page<T> Page<T>(Type[] types, Delegate cb, long page, long itemsPerPage, string sql, params object[] args)

This causes an error when creating a mock Database using Moq. Related to:
castleproject/Core#106

@schotime
Copy link
Owner

schotime commented Apr 1, 2016

What version of the code are you referring to?
https://github.com/schotime/NPoco/blob/dev3.1/src/NPoco/IDatabaseQuery.cs

@GoranSiska
Copy link
Author

master: https://github.com/schotime/NPoco/blob/master/src/NPoco/IDatabaseQuery.cs

I see it's fixed in dev branch.

@schotime
Copy link
Owner

Fixed in master as its been merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants