Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full width test #146

Merged
merged 2 commits into from Nov 20, 2022
Merged

Fix full width test #146

merged 2 commits into from Nov 20, 2022

Conversation

oerlikon
Copy link
Contributor

I noticed that when running go test -bench. it handles stdout and stderr in some different way, so term.GetSize() manages to get the actual size of the current terminal and cause TestOptionFullWidth to fail, so here is the fix.

There was also another test that wasn't actually checking anything and I fixed that one as well.

@schollz
Copy link
Owner

schollz commented Nov 20, 2022

Thanks, I appreciate that!! Its a great help.

@schollz schollz merged commit 502db75 into schollz:main Nov 20, 2022
@oerlikon oerlikon deleted the fix-full-width-test branch November 20, 2022 23:53
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Jan 1, 2023
…#6176)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/schollz/progressbar/v3](https://togithub.com/schollz/progressbar) | require | patch | `v3.12.1` -> `v3.12.2` |

---

### Release Notes

<details>
<summary>schollz/progressbar</summary>

### [`v3.12.2`](https://togithub.com/schollz/progressbar/releases/tag/v3.12.2)

[Compare Source](https://togithub.com/schollz/progressbar/compare/v3.12.1...v3.12.2)

#### What's Changed

-   Add minor fix for full width mode by [@&#8203;oerlikon](https://togithub.com/oerlikon) in [schollz/progressbar#145
-   Fix full width test by [@&#8203;oerlikon](https://togithub.com/oerlikon) in [schollz/progressbar#146

**Full Changelog**: schollz/progressbar@v3.12.1...v3.12.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC40Mi4wIiwidXBkYXRlZEluVmVyIjoiMzQuNDIuMCJ9-->
kodiakhq bot pushed a commit to cloudquery/plugin-sdk that referenced this pull request Jan 1, 2023
…#547)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/schollz/progressbar/v3](https://togithub.com/schollz/progressbar) | require | patch | `v3.12.1` -> `v3.12.2` |

---

### Release Notes

<details>
<summary>schollz/progressbar</summary>

### [`v3.12.2`](https://togithub.com/schollz/progressbar/releases/tag/v3.12.2)

[Compare Source](https://togithub.com/schollz/progressbar/compare/v3.12.1...v3.12.2)

#### What's Changed

-   Add minor fix for full width mode by [@&#8203;oerlikon](https://togithub.com/oerlikon) in [schollz/progressbar#145
-   Fix full width test by [@&#8203;oerlikon](https://togithub.com/oerlikon) in [schollz/progressbar#146

**Full Changelog**: schollz/progressbar@v3.12.1...v3.12.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC40Mi4wIiwidXBkYXRlZEluVmVyIjoiMzQuNDIuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants