Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume int for new progress bar #129

Open
mih-kopylov opened this issue Jul 27, 2022 · 1 comment
Open

Consume int for new progress bar #129

mih-kopylov opened this issue Jul 27, 2022 · 1 comment

Comments

@mih-kopylov
Copy link

When creating a new progress bar based on some collection length, it requires casting to int64.

bar := progressbar.Default(int64(len(sets.Repos)))

Not really nice, though I understand why it's int64 there.

Is there a change to consume int aside of int64?
@schollz
Copy link
Owner

schollz commented Aug 7, 2022

yeah seems like a job for generics, now that they are available. Would accept a PR for this

@hexnaught hexnaught mentioned this issue Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: use generics for new progressbar creation hexnaught/progressbar
2 participants
@schollz @mih-kopylov