Revert PR #113 #123
Merged
Revert PR #113 #123
+48
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, thank you. I appreciate someone fixing my issue properly lol. |
|
thanks! I appreciate the fix @bodgit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my comment here: #108 (comment)
The original PR is/was wrong in that it mixes up
os.Stdoutandos.Stderrwhich might appear to produce the correct behaviour until you use some shell redirection to send one of those two outputs somewhere other than the controlling terminal.If the progress bar is writing to
os.Stderrthen that final newline should also be sent to the same destination; the code was originally correct.This PR reverts the original commit made in #113 but before I did that, I updated the two tests that use
DefaultBytes()to ensure that nothing ever gets written toos.Stdoutby the progress bar code. These tests obviously fail initially, but then pass with the reverted commit.