draft of a fix for proper behaviour on terminal window downsize #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe565
added a commit
to clevyr/kubedb
that referenced
this pull request
Jul 9, 2022
This commit can be reverted if schollz/progressbar#112 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of code that should fix #106. Right now it only works with
useANSICodesoption (which isfalseby default).I don't know how it can be done without ANSI codes, because we need to clear previous lines. I guess it can be achieved with some package for terminal support (other than
term), that can move cursor between lines. Though a quick research shows that most popular packages like atomicgo/cursor also use ANSI codes 😃Would like to hear any helpful comments about the code and any thoughts on the best way to fix the issue.