New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update only if changed #18
Conversation
doRequest(getGistOptions, JSON.stringify({})).then(oldGist => { | ||
if (oldGist.statusCode < 200 || oldGist.statusCode >= 400) { | ||
// print the error, but don't fail the action. | ||
console.log( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Schneegans because every run of action will go over this request, I think it should be changed from console.log
to core.setFailed
. In case the user will enter the wrong gistId
, it should fail.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right, it could fail early at this point. However, it will fail anyways when the action will later try to update the gist.
No description provided.