Added a new feature to allow a color range #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the Range can be inverted and doesn't use the message anymore
Fixed by adding back 'console.' which was removed for testing
Schneegans
requested changes
Apr 16, 2022
LucasWolfgang
commented
Apr 16, 2022
Co-authored-by: Simon Schneegans <code@simonschneegans.de>
Removed automatically set message. Co-authored-by: Simon Schneegans <code@simonschneegans.de>
Reduce the lightness from 50% to 40%.
LucasWolfgang
commented
Apr 17, 2022
LucasWolfgang
commented
Apr 17, 2022
🎉 Added saturation and lightness parameters to ColorRange feature
LucasWolfgang
commented
Apr 17, 2022
LucasWolfgang
commented
Apr 17, 2022
LucasWolfgang
commented
Apr 17, 2022
🎉 Added saturation and lightness parameters to ColorRange feature
|
I'll do some minor formatting stuff and write some documentation after this is merged. Thanks again! I'm looking forward to your future contributions 😉 |
Schneegans
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added a feature in this fork that allows the user to define a range and provide a value using 3 new arguments, 'min', 'max' and 'value'. I felt the need of having such feature when running workflows that provided a score and not just a pass/fail response, such as pylint.
The new section in the index.json file makes sure the value provided is within the range and calculate a color betwen green and red, providing a HSL value to shield.io, besides also formating the resulting message.
One last parameter was added, which allows the user to invert the range, making the smaller value green, and a bigger one, red. This is useful for tests that return number of error, such as flake 8