Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ^5.0 in composer.json for symfony dependencies #777

Conversation

FabienSalles
Copy link
Contributor

#hackdayparis

@goetas
Copy link
Collaborator

goetas commented Oct 30, 2019

you are forgetting

- SYMFONY_VERSION=^3.4 JMS_VERSION=^2.2

@goetas
Copy link
Collaborator

goetas commented Oct 30, 2019

If you are willing to contribute to open-source, I suggest you to read https://www.goetas.com/blog/make-the-difference-when-contributing-to-open-source/ :)

Add next symfony version in travis-ci
Change minimum-stability to dev for composer
@FabienSalles
Copy link
Contributor Author

you are forgetting

- SYMFONY_VERSION=^3.4 JMS_VERSION=^2.2

Thanks for your quick response and sorry for the delay by my side.
It should be ok now !

If you are willing to contribute to open-source, I suggest you to read https://www.goetas.com/blog/make-the-difference-when-contributing-to-open-source/

What would you have wanted me to do to improve my contribution ?

@goetas
Copy link
Collaborator

goetas commented Nov 23, 2019

Symfony 5.0 has been released, I think that the minimum stability dev rule can be removed now

@goetas
Copy link
Collaborator

goetas commented Nov 24, 2019

squash merged in 209d2a3

@goetas goetas closed this Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants