Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example code for "Changing the Object Constructor" section does not show on the web page. #601

Closed
rgembalik opened this issue Aug 21, 2017 · 3 comments

Comments

@rgembalik
Copy link

http://jmsyst.com/bundles/JMSSerializerBundle/master/configuration#changing-the-object-constructor
Mentioned section should contain configuration examples mentioned in the source code here:
https://github.com/schmittjoh/JMSSerializerBundle/blob/master/Resources/doc/configuration.rst#changing-the-object-constructor

At the time of writing this section is followed up by the next section which confuses the reader.
image

@goetas
Copy link
Collaborator

goetas commented Aug 21, 2017

PR are welcome :)

@kinow
Copy link
Contributor

kinow commented Jul 24, 2018

@goetas confirmed in the website that it's now looking OK! So I reckon this issue can also be closed 🎉

Thanks for reviewing the pull request so quickly!

@goetas
Copy link
Collaborator

goetas commented Jul 24, 2018

thank to you for taking the time for this improvement

@goetas goetas closed this as completed Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants