From 2cb36ae934d2c74a7a7c23bae5270aef8a3a05aa Mon Sep 17 00:00:00 2001 From: gambit Date: Mon, 12 Nov 2018 18:01:29 +0300 Subject: [PATCH 1/2] EventDispatcher - use case sensitive event names; --- .../Compiler/RegisterEventListenersAndSubscribersPass.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DependencyInjection/Compiler/RegisterEventListenersAndSubscribersPass.php b/DependencyInjection/Compiler/RegisterEventListenersAndSubscribersPass.php index f0cbc2bb..faf94444 100644 --- a/DependencyInjection/Compiler/RegisterEventListenersAndSubscribersPass.php +++ b/DependencyInjection/Compiler/RegisterEventListenersAndSubscribersPass.php @@ -22,7 +22,7 @@ public function process(ContainerBuilder $container) } $class = isset($attributes['class']) - ? strtolower($container->getParameterBag()->resolveValue($attributes['class'])) + ? $container->getParameterBag()->resolveValue($attributes['class']) : null; $format = isset($attributes['format']) ? $attributes['format'] : null; @@ -52,7 +52,7 @@ public function process(ContainerBuilder $container) throw new \RuntimeException(sprintf('The service "%s" (class: %s) must return an event for each subscribed event.', $id, $subscriberClass)); } - $class = isset($eventData['class']) ? strtolower($eventData['class']) : null; + $class = isset($eventData['class']) ? $eventData['class'] : null; $format = isset($eventData['format']) ? $eventData['format'] : null; $method = isset($eventData['method']) ? $eventData['method'] : EventDispatcher::getDefaultMethodName($eventData['event']); $priority = isset($eventData['priority']) ? (integer)$eventData['priority'] : 0; From a34c75e76d2cb9b75ade7c63262e3eedc4fcfb14 Mon Sep 17 00:00:00 2001 From: gambit Date: Mon, 12 Nov 2018 18:37:54 +0300 Subject: [PATCH 2/2] EventSubscribersAndListenersPassTest fix --- .../EventSubscribersAndListenersPassTest.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Tests/DependencyInjection/EventSubscribersAndListenersPassTest.php b/Tests/DependencyInjection/EventSubscribersAndListenersPassTest.php index 57a0d2c9..bc0dea8c 100644 --- a/Tests/DependencyInjection/EventSubscribersAndListenersPassTest.php +++ b/Tests/DependencyInjection/EventSubscribersAndListenersPassTest.php @@ -121,7 +121,7 @@ public function testEventListener() 'serializer.pre_serialize' => [ [ ['my_listener', 'onserializerpreserialize'], - 'bar', + 'Bar', null ] ]], $call[1][0]); @@ -161,7 +161,7 @@ public function testEventListenerWithParams() 'serializer.pre_serialize' => [ [ ['my_listener', 'onserializerpreserialize'], - 'bar', + 'Bar', null ] ]], $call[1][0]); @@ -196,7 +196,7 @@ public function testEventSubscriber() 'serializer.pre_serialize' => [ [ ['my_listener', 'onserializerpreserialize'], - 'bar', + 'Bar', 'json', null ]