Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UTF-8 message errors #327

Merged
merged 3 commits into from
Apr 30, 2018
Merged

Conversation

drakmail
Copy link
Contributor

Without this fix I got questions instead chars:

"������������������ ������������"

@barakwei
Copy link

👍

@voxik
Copy link

voxik commented Sep 12, 2017

This seems to be similar to #318

@voxik
Copy link

voxik commented Sep 12, 2017

And #304

@voxik
Copy link

voxik commented Sep 12, 2017

And #301

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@stale
Copy link

stale bot commented Apr 29, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 29, 2018
@voxik
Copy link

voxik commented Apr 29, 2018

@perlun since you added the bot, is this going to be merged/fixed prior the bot closes it?

@stale stale bot removed the wontfix label Apr 29, 2018
@perlun
Copy link
Contributor

perlun commented Apr 30, 2018

@voxik I think perhaps auto-closing PRs is a bit too aggressive. Issues is one thing, but open PRs should perhaps be exempt from auto-closing; we don't have that many PRs at the moment so I think manual action to go through them is better than auto-closing.

Thanks for letting me know.

1 similar comment
@perlun
Copy link
Contributor

perlun commented Apr 30, 2018

@voxik I think perhaps auto-closing PRs is a bit too aggressive. Issues is one thing, but open PRs should perhaps be exempt from auto-closing; we don't have that many PRs at the moment so I think manual action to go through them is better than auto-closing.

Thanks for letting me know.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@perlun perlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Will merge once the CI run is done.

@perlun perlun merged commit fe680f8 into ruby-git:master Apr 30, 2018
@drakmail
Copy link
Contributor Author

Thank you for merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants