-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UTF-8 message errors #327
Conversation
👍 |
This seems to be similar to #318 |
And #304 |
And #301 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@perlun since you added the bot, is this going to be merged/fixed prior the bot closes it? |
@voxik I think perhaps auto-closing PRs is a bit too aggressive. Issues is one thing, but open PRs should perhaps be exempt from auto-closing; we don't have that many PRs at the moment so I think manual action to go through them is better than auto-closing. Thanks for letting me know. |
1 similar comment
@voxik I think perhaps auto-closing PRs is a bit too aggressive. Issues is one thing, but open PRs should perhaps be exempt from auto-closing; we don't have that many PRs at the moment so I think manual action to go through them is better than auto-closing. Thanks for letting me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. Will merge once the CI run is done.
Thank you for merge! |
Without this fix I got questions instead chars:
"������������������ ������������"