Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalTime value extraction from ResultSet drops microseconds part #952

Open
seratch opened this issue Oct 13, 2018 · 3 comments
Open

LocalTime value extraction from ResultSet drops microseconds part #952

seratch opened this issue Oct 13, 2018 · 3 comments
Labels
core good first issue
Milestone
version 5 or later

Comments

@seratch
Copy link
Member

seratch commented Oct 13, 2018

I do think there is another issue, this time with LocalTime -it gets saved with milliseconds and not microseconds. So this time saving works incorrectly

#945 (comment)
@seratch seratch added the core label Oct 13, 2018
@seratch
Copy link
Member Author

seratch commented Oct 13, 2018

The current implementation (version 3.3.1): https://github.com/scalikejdbc/scalikejdbc/blob/3.3.1/scalikejdbc-core/src/main/scala/scalikejdbc/Binders.scala#L168-L172

@xuwei-k
Copy link
Member

xuwei-k commented Oct 15, 2018

Should we use java.sql.Timestamp instead of java.sql.Time? 🤔

@gytisgreitai
Copy link

AFAIK the problem is in saving not in retrieving this time

@seratch seratch added this to the version 4.1.x milestone Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core good first issue
Milestone
version 5 or later
Development

No branches or pull requests
3 participants
@seratch @xuwei-k @gytisgreitai