Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New artifact name #14

Open
ashawley opened this issue Oct 2, 2019 · 4 comments
Open

New artifact name #14

ashawley opened this issue Oct 2, 2019 · 4 comments

Comments

@ashawley
Copy link

ashawley commented Oct 2, 2019

I noticed that the artifact name was changed to scalacheck-1.14. It was previously set to scalatest-scalacheck. Was this intentional? The convention for most Scala packages that provide extensions to upstream projects is to prefix their package name and suffix the upstream project. It probably helps avoid confusion about whether the project is a fork, or just an integration of a project.

@ashawley
Copy link
Author

ashawley commented Oct 2, 2019

Also, there are a number of projects using the previous name:

https://mvnrepository.com/artifact/org.scalatestplus/scalatestplus-scalacheck

@sloshy
Copy link

sloshy commented Dec 4, 2019

To add to this: the new name is really incompatible with how people are updating packages these days with scala steward. Say Scalacheck bumps up to 1.15.x, how will I know there's a new version since the artifact name will likely change as well? I'll have to find out through other means rather than using an SBT plugin or relying on scala steward to make an MR for me.

@ashawley
Copy link
Author

ashawley commented Dec 4, 2019

That's less of a concern. The ScalaTest team needs a way to support multiple minor versions of ScalaCheck, so adding the ScalaCheck version name to the artifact name probably makes sense.

@ashawley
Copy link
Author

While upgrading the Scala Community build to ScalaTest 3.1, @SethTisue ran in to this issue.

scala/community-build#1044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants