Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepwiseNestedSuiteExecution Async Support #2211

Conversation

cheeseng
Copy link
Contributor

@cheeseng cheeseng commented Dec 6, 2022

  • Adjusted code in StepwiseNestedSuiteExecution to work with async test.
  • Updated scaladoc in StepwiseNestedSuiteExecution.scala about passing down None for distributor field, it no longer true.

@@ -28,7 +28,7 @@ import collection.mutable.ListBuffer
* Trait that causes the nested suites of any suite it is mixed into to be run sequentially even if
* a <a href="Distributor.html"><code>Distributor</code></a> is passed to <code>runNestedSuites</code>. This trait overrides the
* <code>runNestedSuites</code> method and fowards every parameter passed to it to a superclass invocation
* of <code>runNestedSuites</code>, except it always passes <code>None</code> for the <code>Distributor</code>.
* of <code>runNestedSuites</code>, and make the nested suites are run and completed one after one in order.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that something is missing in this sentence, perhaps:

Suggested change
* of <code>runNestedSuites</code>, and make the nested suites are run and completed one after one in order.
* of <code>runNestedSuites</code>, and make sure the nested suites are run and completed one after one in order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jespermbyskov You're right, I'll make correction, thanks for catching it! :)

@cheeseng cheeseng merged commit 9b42d40 into scalatest:3.2.x-new Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants