Differ Enhancement #2177
Merged
Differ Enhancement #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in Prettifier to prettify element in the diff result.
…t size of prettifier when available.
…t size of prettifier when available.
…t size of prettifier when available.
bvenners
reviewed
Oct 30, 2022
|
|
||
| val shortName = Differ.simpleClassName(aSet) | ||
| println("####shortName: " + shortName + ", ") | ||
| if (missingInLeft.isEmpty && missingInRight.isEmpty) |
There was a problem hiding this comment.
Did you intend to remove this println?
bvenners
reviewed
Oct 30, 2022
| prettifier match { | ||
| case tp: TruncatingPrettifier => tp.sizeLimit.value | ||
| case _ => math.max(aMap.size, bMap.size) | ||
| } |
There was a problem hiding this comment.
This match seems to be repeated 3 times. Perhaps factor out into a method?
|
@bvenners Thanks for reviewing, I have made the adjustments can you see if it is fit now? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced GenSeqDiffer, GenSetDiffer and GenMapDiffer to support find diff elements according to limit size of prettifier when available.