Style Traits + Matchers DSL Infix #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvenners
reviewed
Nov 11, 2022
| @@ -273,6 +276,7 @@ trait AnyFreeSpecLike extends TestSuite with TestRegistration with Informing wit | |||
| * implementation of this method will register the text (passed to the contructor of <code>FreeSpecStringWrapper</code> | |||
| * and immediately invoke the passed function. | |||
| */ | |||
| //DOTTY-ONLY infix | |||
| def -(fun: => Unit): Unit = { | |||
There was a problem hiding this comment.
@cheeseng This one is not needed, because - is symbolic.
bvenners
reviewed
Nov 11, 2022
| @@ -279,6 +282,7 @@ trait AsyncFreeSpecLike extends AsyncTestSuite with AsyncTestRegistration with I | |||
| * implementation of this method will register the text (passed to the contructor of <code>FreeSpecStringWrapper</code> | |||
| * and immediately invoke the passed function. | |||
| */ | |||
| //DOTTY-ONLY infix | |||
There was a problem hiding this comment.
@cheeseng Another infix that's not needed.
bvenners
reviewed
Nov 11, 2022
| @@ -355,6 +360,7 @@ trait FixtureAnyFreeSpecLike extends org.scalatest.FixtureTestSuite with org.sca | |||
| * implementation of this method will register the text (passed to the contructor of <code>FreeSpecStringWrapper</code> | |||
| * and immediately invoke the passed function. | |||
| */ | |||
| //DOTTY-ONLY infix | |||
| def -(fun: => Unit): Unit = { | |||
There was a problem hiding this comment.
@cheeseng And another. I'll add a commit to remove these.
bvenners
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Scala 3 infix modifier to style traits DSL and remaining matchers DSL.