Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlReporter: missing a "throw" #2138

Merged
merged 1 commit into from Jul 20, 2022
Merged

HtmlReporter: missing a "throw" #2138

merged 1 commit into from Jul 20, 2022

Conversation

nafg
Copy link
Contributor

@nafg nafg commented Jul 5, 2022

Unless I'm missing something, this line was doing nothing

@cla-bot
Copy link

cla-bot bot commented Jul 5, 2022

Hi @nafg, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.

@artimasites
Copy link

@cla-bot[bot] check

@cla-bot cla-bot bot added the cla-signed label Jul 5, 2022
@cla-bot
Copy link

cla-bot bot commented Jul 5, 2022

The cla-bot has been summoned, and re-checked this pull request!

@cheeseng
Copy link
Contributor

cheeseng commented Jul 5, 2022

@nafg Fyi in main (for the upcoming 3.3) we have switched to commonmark, I have cherry-picked your commit into 3.2.x-new branch and submitted the following PR:

#2139

and for main branch I included your commit in this PR:

#2140

Cheers.

@cheeseng cheeseng merged commit 20dfc9d into scalatest:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants