Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark classes as 'open' #2176

Open
charpov opened this issue Oct 28, 2022 · 1 comment
Open

Mark classes as 'open' #2176

charpov opened this issue Oct 28, 2022 · 1 comment

Comments

@charpov
Copy link

charpov commented Oct 28, 2022

Nothing major and nothing urgent, but classes that are designed for extension, such as Tag or Suites should be marked as open to avoid warnings when compiling with the -source:future option.

@cheeseng
Copy link
Contributor

@charpov Thanks for pointing out, that's definitely should be done, I have just submitted the following PR for this:

#2178

Do let us know if you notice more classes that should be marked as 'open'.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants