Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettifier not being used for property + future check #2174

Open
mdedetrich opened this issue Oct 22, 2022 · 7 comments
Open

Prettifier not being used for property + future check #2174

mdedetrich opened this issue Oct 22, 2022 · 7 comments

Comments

@mdedetrich
Copy link
Contributor

mdedetrich commented Oct 22, 2022

So in PR #2155 I fixed the Prettifier so that it works on case classes however I noticed that its still not being applied even when using implicit val prettifier: Prettifier = Prettifier.truncateAt(SizeLimit(10)), i.e. with ScalaFutures (i.e. .futureValue) plus AnyPropSpecLike (i.e. property)

[info] - basic flow without interruptions using PeriodFromFirst works correctly *** FAILED ***
[info]   TestFailedException was thrown during property evaluation.
[info]     Message: The future returned an exception of type: org.apache.kafka.common.errors.TopicExistsException, with message: Topic '3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__' is marked for deletion..
[info]     Location: (RealS3BackupClientTest.scala:155)
[info]     Occurred when passed generated values (
13:39:34.169 [RealS3GzipCompressionBackupClientSpec-akka.kafka.default-dispatcher-22] WARN  org.apache.kafka.clients.NetworkClient - [Consumer clientId=consumer-jHvePKjywnEQQhTfazjfZSpazLIKrmT-3, groupId=jHvePKjywnEQQhTfazjfZSpazLIKrmT] Error while fetching metadata with correlation id 2290 : {3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__=LEADER_NOT_AVAILABLE, _.1_5.-9...4..-M-.-4U2__._-._7s.xb-1-11-__M--930.8-Q_.Z_._w6-___6v-.1-__9_T_-_4__6___-_.Y-..C4_Q_-0.2N9__-5._-Y-_5e_-w1.Wg.8_.-.._H36_W-_-2z-3..0_.-__-K-c.--_.._1_fYvB.6.6PP-8K.--_UL36G_0-M.-..LOX--=LEADER_NOT_AVAILABLE}
13:39:34.256 [RealS3BackupClientSpec-akka.actor.default-dispatcher-36] INFO  io.aiven.guardian.kafka.backup.s3.BackupClient - Found previous uploadId: lHgmPlCns3yyHrDaUmHpDuCAmjfbkmut9NjSAIrSxh8lwCUhi81gdNkC9gx8Ey58DdvTmegijAE3RIxu.uqBec4exACMYLdPFZx1KEnYhiv0G5j66tdSKexQhoUrVkJx and bucket: guardian-ghngevysrdtcxcwy-kox-mivpyjhbpyffez--q-pfb-6ax3 with key: 2022-10-22T11:37:50.045Z.json
[info]       arg0 = KafkaDataInChunksWithTimePeriod(List(List(ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,0,Some(Zw==),bXF3SEhRUlRublZ2QVVNVFI=,1,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,1,Some(Zw==),bmtaV0Q=,4,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,2,Some(aQ==),dEFJaGxGd1ZUZE1VRnNKUmhQZGRCZm1EY1NERFJjdWdabmtzaHlTSXFGdENVVU9IdXdvSFBGd1JEdEdOakRVUm9iT1ZLa3pnbG0=,8,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,3,Some(aQ==),SXlFcmc=,15,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,4,Some(Zw==),RFVlcXliS2xaa3pwS1JMcHdST1hQQmJvSXhQQkN2Sk5GamxWc3RXQ253enZHUHB6Qk5zbUJTc3hPWlR4VnFTdHNiV0hncmdob1hMZkxMQUJuWGJDT2xMc3Vhc3J4TWdOdEw=,25,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,5,Some(Zw==),eG1UUEZ6d0VnYVRVakRBdFZZdmNRY0tPa3dVTmJvU0hVSlVBT2Jvc0JIZVNHdEFOa3ZubElYeXZlVmZycXdxQkh6SXVyTXdBREtLWVVGVw==,32,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,6,Some(aQ==),VG5rZ1NudmtOc3FERFljYWdJaFBWSUVFc2VXR1pEdVh3UklDanlMYm1ISXFzSXBiYW5STXJYV3l4cUljZEpRSlZaVnRWRmZ6a0tiSkFyUQ==,33,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,7,Some(aQ==),Y25jTGZUR1dGUkFJd1hKRWhkRFpKYUpvcnh3VQ==,41,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,8,Some(Zw==),dGdEZ0VLT09OcmFZeVN2am5jZ3NxTE9FR2ZOSmplb3hzUmJoR3lwYVlFdkFrbWZwZUdOSEFYa1RWRUtaQlhmTGhNWUZ0R1BXWWdMb2hQWEhkRkhQaWZIdHZZbnJOWFBSdA==,42,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,9,Some(Zw==),a2xsd011eG5ET0dvU0d4U0lxUm9Id1V1cmJVZndseW9aS2RjUndQdXBNRWpyY0dOWnJNa3RFS0h6UWZHVkZZR0hSS091c2t3SWpMbXpQalRKanVWZQ==,52,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,10,Some(Zw==),YXpCbWdi,62,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,11,Some(aQ==),dUltRHpKdmFTSHlka0dsTUhMdXRvZXNCWmFXbmdZSEVyTUFYRkhseWh3eUVGTFBscnBLUW1kZEFYekt5VmRU,72,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,12,Some(Zw==),TkFZdGZDcHR5Vw==,82,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,13,Some(Zw==),S2pjWllsSFNXWVhPTnNVZ3Z2YURwSWt4em5K,91,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,14,Some(Zw==),U3VpQUVXaGJMdG5vZ2VuVkxkUk5XSlFYVXpBcm1kZ2JV,92,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,15,Some(aQ==),UkJJSlZWaEhCUUFHanBUVkVwQ1FIb21lb0pJcXlUSlp1WmhqVHFKekloUWlBbk1saGFvb1B1T3hEaHhjTWZnc3B6T2hNYVZWcWF5ZGFuQ1RZeWNIYg==,93,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,16,Some(aQ==),UEFEQVFIWmRvSVVkb1FUTGJuTXlwUWtPWWpuUnVOSnd6TExlU0lRa3o=,94,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,17,Some(aQ==),WFRReg==,95,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,18,Some(aQ==),akdOckxKSGJUZG16aktqcG90SHdocVFoVnpEeGZZTmZ6bFBISkladw==,96,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,19,Some(aQ==),WUlIQ0V1S3VFYmh6SWh0R2luSmd1QmxvaXNYU2ZSUEVBbHh1Q0tTZ0dNRVJ1VFJLZlJIb1lockdQcm1jZmpEY0ZqdWNHcEVOS2FMRUl2eEZzTEtLblROeGVSRGFXZQ==,97,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,20,Some(aQ==),Y3p1c3dQSWU=,98,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,21,Some(aQ==),UnVhWEdxRUdmRE1mRmlTcnlPeU9zbmZkZFRrUGx1d3R0eHBhck1GTWRWb05RUUV1VEpmRXRZem9XeU5DZlF0Sk11bw==,103,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,22,Some(Zw==),YXV6U2V0alpmT1JYWm1pQllFU01GSUxMVU1XeXlkR0tIeENZelpNdENkSFV4QklJcG1sWHBSbkFzaUVSaGNVVVpXTmRVdHRZa1NwV3VhSkx1bnNqWUVRWVFOZVFMVVQ=,113,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,23,Some(aQ==),RnZBVFVPU3ljakdxdmNSUndVZkxNR1NHb1FrTFVsVEJBZGdqSEpqYmJYZ1BlSWZkQ2RmdUtFUHZXS3BKRkJTZElvTU5wUFF6YXV3SHBCZUZyUUhhZ054,114,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,24,Some(aQ==),SUd3bk5QeGVlbk9FeXdlcmREV05z,124,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,25,Some(aQ==),WU9zYWxVT1pMc0t6QXh1Yk5aZ1luRGVTTHR5WHNJZHhaTGxzR01yaGlla1lQUUVOeXh5TnVIQlhIektvZnFobE1FZVZRdXJOSGtzV1FwaEhBZg==,131,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,26,Some(aQ==),T1lSbWdzUUFFbkFvbmp0SmR2Z0VVWnNOb3lKUEpJSlhwanRhZ2FxWldIWE1rR294V3ZyVXQ=,137,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,27,Some(aQ==),Q1hnTk9nVGNrbnRoVXZKR1BlQkhWalN4ZU5XSElseUVQeG5ZQ1lDd3BLaEhjUU1SSnV1anhjbWhmaU1kUnd3Wnp3ckhkaVhaaXFYcVNRQUxTZm9FaVB6VklUcUg=,138,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,28,Some(Zw==),SmNUa2tpd1NmUUh0SG13aVRmTndlR3ZxWGpK,146,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,29,Some(Zw==),a0R4ZVBRWU5zb0pUUlJpeGFOc3hHZ05pY1lFSnJyQXlERWtzaExFVXNkZXdUd1dxb0Vzbw==,147,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,30,Some(Zw==),ellMbG5CY2FLUFlabHpSWE15Q0RmalQ=,157,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,31,Some(Zw==),a0NQdllVakhtYVlOak5tZnhRYnZBdENFbGhRcmJidWlnRA==,158,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,32,Some(Zw==),dVdMZ3Jma2RHa256RXdtR1hkQ3VmbE9aY29qQWFBbXNXZEtXeExwbEFDcHZ6QmdDTFpDU2lpSGd6WGpBUFNRSnZ1bUdyZmNTVXNWcWlTZGpxaUlz,159,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,33,Some(Zw==),d3V5a0J0VmZZSk9YeWVr,167,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,34,Some(Zw==),VlJVWFBvT0JrVWF2c25BV3J3V2FYdFJnT3NlZktOT1VaWG9GakZZR2FUTkV4YQ==,173,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,35,Some(Zw==),emJVZ25LcXBiRGJuU09tTWZud1NCdXhKckhBUXFGcmdRUW55empFQ0VNc29MZGFGbnFreGFPSVpiQk5qU2F4ZElxUHR4a2tIdFNzaGE=,174,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,36,Some(Zw==),SUZna1JCbVNZY2VlYUpkeGpoTVlNZ0lMY2pQamRBSWZvRGFBalV1cGZac2JJZkZvZWNNWWl3,176,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,37,Some(Zw==),V25RWHdEcklTVEJ3ZXlOSVRrVXliamJtWFN2cWdMSU9Zd3Vtb1ZEZU9LdGNLR2pkeUFoVGhzZ1d1V216ZmphTkdz,177,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,38,Some(aQ==),WXV0bk1td3VxVm5XZ0ltRnRlUW1hWEpPWnhhcVhFamJGZ09jQ0FhWVRkWmhxTlJlbkp1R3pGandSUXBuS1dxTEJJQkFrWkhMY3JIdnh1elJoeXJvY0ZnSFVUYms=,187,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,39,Some(Zw==),d25FWm5iVmZiWGpHRXdFYWp2amZuV3BvTA==,197,CreateTime), ReducedConsumerRecord(3.iT.AAf--_.-2.T.93-58_M._._-_21.F-f-_.._.--.P._X._2_-_y.s_-___--_56_c-_5_-g-x.I---.26y7_j__55b_Z--_d_._9._A1-__-20-r_-5.2_.i99--._w._.--2..__E.92K--.13wt-5_...-1T.--U2Qm_-.-_0o_-_C.s3H.-_6---_w_..--h_..-k23__,0,40,Some(aQ==),ZEtkTFp5ZFVkV1VuSElYZmRVV09tSw==,207,CreateTime)
(Keeps on going since its not truncated)

The test can be seen at https://github.com/aiven/guardian-for-apache-kafka/blob/main/backup-s3/src/test/scala/io/aiven/guardian/kafka/backup/s3/RealS3BackupClientTest.scala#L95-L170 and the Prettifer is defined at https://github.com/aiven/guardian-for-apache-kafka/blob/main/core-s3/src/test/scala/io/aiven/guardian/kafka/s3/S3Spec.scala#L62 (note I have verified via Metals that the implicit is being used by the test).

I wanted to debug this further, the code that is meant to be prettifying this statement is in PropCheckerAsserting specifically in the function

private[enablers] def failureStr(failure: PropertyCheckResult.Failure, outerEx: StackDepthException, prettifier: Prettifier, argNames: Option[List[String]], labels: List[String]): String

However for some reason I can find no reference to it in published jars (even though its included in commonTest project) in order to debug the test to figure out precisely whats going on.

@mdedetrich mdedetrich changed the title Prettifier not being used for property check Prettifier not being used for property + future check Oct 22, 2022
@cheeseng
Copy link
Contributor

@mdedetrich I am trying to look into this now, I think the one in commonTest shouldn't be the one you are after, the related code probably is in scalatest+scalacheck, I'll try to look that up.

By the way I think your PR #2173 is a good one, though we should target 3.2.x-new so we can include in the next 3.2.15 release. Any reason you closed it?

Cheers.

@cheeseng
Copy link
Contributor

@mdedetrich fyi the related asserting class should be this:

https://github.com/scalatest/scalatestplus-scalacheck/blob/main/scalatestPlusScalaCheck/src/main/scala/org/scalatestplus/scalacheck/CheckerAsserting.scala

I need to attend to lunch now, I'll dig further

@cheeseng
Copy link
Contributor

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Oct 23, 2022

By the way I think your PR #2173 is a good one, though we should target 3.2.x-new so we can include in the next 3.2.15 release. Any reason you closed it?

It caused test to fail and I just noticed that it was the wrong project (it was for Scalatest on JS, not JVM however I see that you noticed the exact same problem in a different project at #2174 (comment), will open the PR with that fix.)

Do you want me to re-open the original PR as well?

@mdedetrich
Copy link
Contributor Author

@cheeseng I have opened a new PR with your suggested fix to the correct project at scalatest/scalatestplus-scalacheck#57 and also re-opened #2173 and also made it based on 3.2.x-new. Let me know if you want me to add a test (and if so where).

@cheeseng
Copy link
Contributor

cheeseng commented Oct 23, 2022

@mdedetrich To continue our conversation from the closed #2173 , I think the following function is the cause for the problem you are seeing:

https://github.com/scalatest/scalatestplus-scalacheck/blob/main/scalatestPlusScalaCheck/src/main/scala/org/scalatestplus/scalacheck/CheckerAsserting.scala#L327

It is not sync with what supported in our latest Prettifier, I'll try to write a unit test in scalatest+scalacheck and see if I can reproduce the problem, before trying to fix it.

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Oct 23, 2022

@mdedetrich To continue our conversation from the closed #2173 , I think the following function is the cause for the problem you are seeing:

https://github.com/scalatest/scalatestplus-scalacheck/blob/main/scalatestPlusScalaCheck/src/main/scala/org/scalatestplus/scalacheck/CheckerAsserting.scala#L327

It is not sync with what supported in our latest Prettifier, I'll try to write a unit test in scalatest+scalacheck and see if I can reproduce the problem, before trying to fix it.

Perfect, you are right I think its not just the prettifier function. If you want you can commit directly ontop of my PR at scalatest/scalatestplus-scalacheck#57 or make a new PR as you see fit.

cheeseng added a commit to scalatest/scalatestplus-scalacheck that referenced this issue Oct 25, 2022
…supported in current version of Prettifier in scalactic, this fixed the intended Prettifier not being used problem as filed here: scalatest/scalatest#2174 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants