Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be strict about naming for Folder (only for in-db dashboard folders) vs Directory (for actual filesystem) #7780

Open
fm3 opened this issue May 2, 2024 · 0 comments
Open

Be strict about naming for Folder (only for in-db dashboard folders) vs Directory (for actual filesystem) #7780

fm3 opened this issue May 2, 2024 · 0 comments
Labels
backend refactoring

Comments

@fm3
Copy link
Member

fm3 commented May 2, 2024 •
edited

There are a couple of spots where we use the terms interchangeably (at least folder for filesystem stuff). Not a huge issue, but I think it would be nice to use the words strictly as in the issue title, in order to immediately know what to look for.

This also concerns the config options datastore.baseFolder and datastore.localFolderWhitelist (config migration will be needed. also referenced in messages file)
@fm3 fm3 changed the title Be strict about Folder (only for in-db dashboard folders) vs Directory (for actual filesystem) Be strict about naming for Folder (only for in-db dashboard folders) vs Directory (for actual filesystem) May 2, 2024
@fm3 fm3 mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fm3