Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for Unicode supplementary characters in identifiers and string interpolation (as in Scala 2) #16271

Closed
som-snytt opened this issue Nov 1, 2022 · 3 comments · Fixed by #16278
Assignees
Milestone

Comments

@som-snytt
Copy link
Contributor

Minimized code

Welcome to Scala 3.2.0 (19, Java OpenJDK 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.

scala> val Trying to highlight erroneous position <7..7>. Input size: 6
😈 = 42
-- Error: --------------------------------------------------------------------------------------------------------------
1 |val 😈 = 42
  |    ^
  |    illegal character '\ud83d\ude08'

scala>

Shotput

Gave it a shot.

Expectation

https://twitter.com/SethTisue/status/1587184657141039110

@som-snytt som-snytt added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Nov 1, 2022
@SethTisue
Copy link
Member

SethTisue commented Nov 1, 2022

“Demon fails to compile” sounds like Satan wanted a list made of who’d been naughty but his minion just cashed the check and never delivered

@som-snytt
Copy link
Contributor Author

Little-known fact, Santa does outsource it, and this is the only reason we ever get any presents.

@bishabosha bishabosha added area:parser and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Nov 1, 2022
@som-snytt
Copy link
Contributor Author

This is just the backport forward [!] port of the PR mentioned by Seth, scala/scala#9805

Took me a while to remember the subtle difference: the horned face is an operator.

I also see that on the linked PR, I suggested that I would try to refresh my memory and forward port it.

@SethTisue SethTisue changed the title Demon fails to compile Improve support for Unicode supplementary characters in identifiers and string interpolation (as in Scala 2) Nov 2, 2022
@som-snytt som-snytt self-assigned this Nov 2, 2022
SethTisue added a commit that referenced this issue Dec 29, 2022
@Kordyjan Kordyjan added this to the 3.3.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants