TASTy reader: add support for Scala 3.0.0-M3 #9394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
approved these changes
Dec 16, 2020
|
Should we ignore the TRANSPARENT flag on traits? Is that new in M3 or was it already in M2? I forgot. |
SethTisue
reviewed
Dec 16, 2020
yes, that was a change already made for M2 support |
bishabosha
force-pushed
the
tasty/support-3.0.0-M3
branch
from
17a4adf
to
bfea40f
Compare
bishabosha
changed the title
dwijnand
approved these changes
Dec 17, 2020
bishabosha
force-pushed
the
tasty/support-3.0.0-M3
branch
from
0300461
to
bfea40f
Compare
|
dropped the commit to change |
dwijnand
changed the title
|
I think the Travis error seems unrelated |
|
Needs a rebase, the error is about not using sbt-dotty 0.5. |
bishabosha
force-pushed
the
tasty/support-3.0.0-M3
branch
from
bfea40f
to
e91aa06
Compare
|
squashed and rebased |
|
now the CI says the build fails to compile due to cyclic reference error |
|
Could you rebase? I can't push to the scalacenter org, even if it's a PR branch. |
- add changes to TASTy format 26.1 - test compat with cats-effect IOApp.Simple - substitute scala.Matchable for Any - test erasure of ValueOf from dotty
bishabosha
force-pushed
the
tasty/support-3.0.0-M3
branch
from
e91aa06
to
357c2af
Compare
|
rebased |
|
CI looks good |
SethTisue
changed the title
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the minimal thing and substitutes references to
scala.Matchabletoscala.Any,there was no need to add an extra test case for Export clauses in tasty - they were already tested.
Also adds test cases for the updates to trait encoding and Value class erasure in Scala 3
fixes scala/bug#12259
fixes scala/bug#12286