TASTy reader: add support for Scala 3.0.0-M2 #9357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit does not implement backwards compatability for tasty unpickling, perhaps that may be desireable
|
IMO, until 3.0.0 we can afford to support only one version. That's the advantage of a -Y flag. After 3.0.0 we'll have to support all versions since 3.0.0 (like the dotty compiler itself will have to do). |
|
folks needing prompt access to this can use a nightly build of 2.13.5 |
SethTisue
changed the title
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.0.0-M1If we wanted to support both
3.0.0-M1and3.0.0-M2that could be possible at least in this release, future releases of scala 3 may make more serious changes. If we did, I think in tastytest it would be simple enough to support versioned source directories, but mamaging the different scala 3 versions in classloaders would be more trickycc @sjrd