HashMap bulk operations should retain existing keys #9074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeskells
reviewed
Jun 22, 2020
mkeskells
suggested changes
Jun 22, 2020
SethTisue
added
the
prio:blocker
... when the operand overwrites mapping with a key that is == but ne.
This is consistent with the super class implementation, which
was overridden in 2.12.11 for efficiency.
I also found a pair of ClassCastExceptions in the new implementations
of `HashMap.++:`, for instance:
```
case class C(a: Int)(override val toString: String); implicit val Ordering_C: Ordering[C] = Ordering.by(_.a); val c0l = C(0)("l"); val c0r = C(0)("r"); import collection.immutable._; println(HashMap((c0l, ())).++:(TreeMap((c0r, ()))))'; done
v2.12.10
Map(r -> ())
v2.12.11
java.lang.ClassCastException: scala.collection.immutable.HashMap$adder$1$ cannot be cast to scala.collection.immutable.HashMap
at scala.collection.immutable.HashMap$adder$1$.<init>(HashMap.scala:215)
```
|
Suggested changes applied and I've cleaned up casting to |
|
/rebuild |
mkeskells
reviewed
Jun 23, 2020
mkeskells
reviewed
Jun 23, 2020
mkeskells
approved these changes
Jun 24, 2020
SethTisue
removed
the
prio:blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... when the operand overwrites mapping with a key that is == but ne.
This is consistent with the super class implementation, which was
overridden in 2.12.11 for efficiency.
I also found a pair of ClassCastExceptions in the new implementations of
HashMap.++:, for instance:Fixes scala/bug#12047