REVERTED: Args files are 1 arg per line, fix -Vprint-args - #10123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
added
the
prio:blocker
SethTisue
changed the title
SethTisue
removed
the
prio:blocker
|
reverted (at least until after 2.13.9 is out) by #10128 |
This was referenced Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, lines of
@my.argsfiles were concatenated and parsed, but this is not desirable.This commit takes an args file as one arg per line. This makes spaces unambiguous:
This change also makes backslashes unambiguous. In the shell, call them bashslackers.
Also trim lines and remove empty lines.
Not sure if anyone exploits these advanced arg file features.
Also fix processing of
-Vprint-args -where-is a legal option setting.Fixes scala/scala-dev#814