Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sdk install instructions to include the actual version #1560

Open
bjornregnell opened this issue Sep 25, 2023 · 4 comments
Open

update sdk install instructions to include the actual version #1560

bjornregnell opened this issue Sep 25, 2023 · 4 comments

Comments

@bjornregnell
Copy link
Contributor

bjornregnell commented Sep 25, 2023

On this page https://www.scala-lang.org/download/3.3.1.html
it says: sdk install scala

But I need to do

sdk install scala 3.3.1
sdk default scala 3.3.1

if I don't have a fresh install, but already have e.g. 3.3.0 installed.

If I do like in the instructions it for some reason downloads very old 3.1.1 and ask me to set that as default even if I also have 3.3.0 installed as (previous) default.

I'm not sure how sdkman thinks about the latest version of scala and the only safe thing to really get the actual version is to state it explicitly, hence I think the download page for each new version should also add the specific version after sdk install scala.

@bjornregnell
Copy link
Contributor Author

I'm not sure if it is the same issue with brew, but it seems to me natural that explicit version is given also to brew.

@bjornregnell
Copy link
Contributor Author

bjornregnell commented Sep 25, 2023

Sometimes sdk install scala 3.3.1 asks me if it should be the default but not always.

I'm unsure exactly when sdk default scala 3.3.1 is needed after install. But it does not hurt to include it in the instructions.

@bishabosha
Copy link
Member

bishabosha commented Sep 26, 2023

I'm not sure if it is the same issue with brew, but it seems to me natural that explicit version is given also to brew.

brew doesnt really support versioning, you have to manually create a new formula for each "older" version, with Scala so far they are only done by major version, so scala, scala@2.13, scala@2.12 etc

@hamzaremmal
Copy link
Member

I'm not sure if it is the same issue with brew, but it seems to me natural that explicit version is given also to brew.

brew doesnt really support versioning, you have to manually create a new formula for each "older" version, with Scala so far they are only done by major version, so scala, scala@2.13, scala@2.12 etc

I've added scala@3.3 to homebrew last weekend. We now have all the formulas in the core tap :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants