New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: Windows test runs failing in PipelineMainTest, due to sys.process parsing change #814
regression: Windows test runs failing in PipelineMainTest, due to sys.process parsing change #814
Comments
FSR But my first thought is to provide a convenience method or interpolator for adding This parsing is done for args supplied as string, not in a list. The quoting feature is for |
keeping open until we have a green run at https://github.com/scala/scala/actions |
I can't tell if anything progressed, but there are still path errors in tests. Probably tests that construct a string of args with paths interpolated. I'll take a look during lunch break. |
For the record, the error currently (at https://github.com/scala/scala/runs/8119344147) is
|
@som-snytt this is now the only remaining issue preventing us from designating a Scala 2.13.9 release candidate. perhaps we should simply revert scala/scala#10114 (and scala/scala#10123?) and reconsider the change for 2.13.10? one way or the other I would like to designate a release candidate by the end of the day tomorrow (Fri Sep 2) |
@SethTisue reverting is OK. Don't let the good interfere with convenience, or whatever the saying is. |
should I revert 10123 at the same time? |
@SethTisue that is OK. I did look at fixing the tests but why risk a kerfuffle. "This is how I define 'unwarranted'." To quote Star Trek: The Motion Picture that is playing now. |
ok will do |
keeping open until we have a green run at https://github.com/scala/scala/actions |
@som-snytt this is causing the test suite to time out on Windows — not intermittently, every time, at https://github.com/scala/scala/actions/runs/2907898126 but also subsequent runs since then:
on my Mac, I tried inserting
Thread.dumpStack()
at the top ofsys.process.Parser.tokenize
and I see:if that's any help. I believe
PipelineMain
andPipelineMainTest
are @retronym territoryThe text was updated successfully, but these errors were encountered: