Release 2.13.5

[SethTisue]

SCALA_VER_BASE="2.13.5"
SCALA_VER_SUFFIX=""
SCALA_SHA=8cc248dc1305df4c17bb6b5738b700b60c9b5437
DIST_SHA=e40fd600290064904b93f9dd64149022618a2334
SCALA_VER="$SCALA_VER_BASE$SCALA_VER_SUFFIX"

Key links:

• scala/scala milestone: https://github.com/scala/scala/milestones/2.13.5
• scala/bug milestone: https://github.com/scala/bug/milestones/2.13.5
• scala/scala-dev milestone: https://github.com/scala/scala-dev/milestone/37
• Discourse topic: https://contributors.scala-lang.org/t/scala-2-13-5-planning/4825/9
• release notes draft: 2.13.5 release notes #763

N weeks before the release

• Wind down PR queue. There has to be enough time after the last (non-trivial) PR is merged and the next phase. The core of the eco-system needs time to prepare for the final!
• Triage scala/bug and scala/scala-dev tickets
• Create next scala/scala milestone, move the magical "Merge to 2.13.x" description to it (so Scabot uses it as default for new PRs), move pending PRs
• Create next scala/bug milestone, move pending issues
• Create next scala/scala-dev milestone, move pending issues
• Check PRs assigned to the milestone, also check WIP
• Announce expected release date and current nightly "release candidate" (nightly sha-mangled version) at https://scala-ci.typesafe.com/artifactory/scala-integration/ on https://contributors.scala-lang.org/c/announcements
• Also notify Scala Center advisory board members of the upcoming release, so they can help test if they want (Seth can handle this, if asked)

Release announcement / notes

• Notify community on https://contributors.scala-lang.org/c/announcements
• Review merged PRs, make sure release-notes label is applied appropriately
• PRs with release-notes label must have excellent title & description (title will be pasted literally in release note bullet list)
  • https://github.com/scala/scala/pulls?q=milestone%3A2.13.5+is%3Aclosed+label%3Arelease-notes
• Draft release notes (PR and self-merge, so others can comment there rather than on the commits)
• On contributors thread, link to release note file and request feedback

N days before release

• Announce no more PRs will be merged unless last-minute regressions are found. Re-iterate current nightly sha version for testing.
• Community build
  • JDK 8: https://scala-ci.typesafe.com/job/scala-2.13.x-jdk8-integrate-community-build/????
  • JDK 11: https://scala-ci.typesafe.com/job/scala-2.13.x-jdk11-integrate-community-build/????
  • JDK 15: https://scala-ci.typesafe.com/job/scala-2.13.x-jdk15-integrate-community-build/????
• Windows Jenkins job
  • if there isn't already a nightly run on the exact right SHA (check the log), manually trigger one
  • https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-windows/????
• Run test suite (testAll) on JDK 11 (ought to be in CI, but locally for now.)
• Run test suite (testAll) on JDK 15 (ought to be in CI, but locally for now.)
• Check any merged PRs accidentally assigned to the next milestone in this branch, and re-assign them to this milestone
• Merge in any older release branch
• Check module versioning (is everything in versions.properties up to date?)
  • including make sure the version of scala-asm we're using is using latest ASM
• On major release, bump PickleFormat version
• Close the scala/scala and scala/bug milestones

Point of no return

Once sufficient time has passed since last merged PR, it's time to cut the release!

How long we wait depends on what kind of release it is. For a major release, it might be 1-2 weeks, to give core projects time to try out the preceding release candidate and/or the current candidate nightly. For point releases, assuming we've given the community ahead-of-time warning and kept them appraised of progress on the Discourse thread, and assuming the last changes merged seem sufficiently safe, we might build the next day.

• Make sure there are no stray staging repos on sonatype
• Trigger a custom build on travis
  • Select the correct branch
  • Custom config: before_script: export SCALA_VER_BASE=2.13.5 SCALA_VER_SUFFIX=""
    • https://travis-ci.com/github/scala/scala/builds/217832096
    • https://travis-ci.com/github/scala/scala/jobs/485158674
    • https://travis-ci.com/github/scala/scala/jobs/485343386
  • Check the build status on https://github.com/scala/scala/commits/2.13.x
  • Check that the scala/scala job also triggered a following scala/scala-dist job: https://travis-ci.com/scala/scala-dist/builds/?
  • Create the scala/scala tag locally: git tag -s -m "Scala $SCALA_VER" v$SCALA_VER $SCALA_SHA
  • Create scala-dist tag locally: git tag -s -m "Scala $SCALA_VER" v$SCALA_VER $DIST_SHA
  • Note the repos to be promoted after tag is cut (see travis log)
• Sanity check jar/pom
  • https://oss.sonatype.org/content/repositories/staging/org/scala-lang/scala-compiler/2.13.5/
  • in particular, if the release was staged multiple times, double check that https://oss.sonatype.org/content/repositories/staging/ has the files from the most recent build
• Check that JARs haven't mysteriously bloated — compare sizes to previous release. We have no other backstop for this.
• Remember, tags are forever, so are maven artifacts (even staged ones, as they could end up in local caches) and S3 uploads (S3 buckets can be changed, but it can takes days to become consistent)
• Push scala/scala tag: git push https://github.com/scala/scala.git v2.13.5
• Add release notes to https://github.com/scala/scala/releases/tag/v2.13.5
• Push scala/scala-dist tag: git push https://github.com/scala/scala-dist.git v2.13.5
• Trigger two scala-dist jobs on travis (https://travis-ci.com/scala/scala-dist) with custom config. must use full-length SHAs!
  • before_script: export version=2.13.5 scala_sha=8cc248dc1305df4c17bb6b5738b700b60c9b5437 mode=archives: https://travis-ci.com/github/scala/scala-dist/builds/217896025
  • before_script: export version=2.13.5 scala_sha=8cc248dc1305df4c17bb6b5738b700b60c9b5437 mode=update-api: https://travis-ci.com/github/scala/scala-dist/builds/217896042
• Promote staging repos: st_stagingRepoPromote [scala-repo], st_stagingRepoPromote [modules-repo] (or use oss.sonatype.org web UI)

Check availability

• Check release on sonatype: https://oss.sonatype.org/content/repositories/releases/org/scala-lang/scala-compiler/2.13.5/
• Check the release on maven central: https://repo1.maven.org/maven2/org/scala-lang/scala-compiler/2.13.5/

When everything is on maven central

• Prepare PR to https://github.com/scala/scala-lang/ (using scala/make-release-notes which requires a staged release and a pushed tag)
  • documentation/api.md
  • download/index.md
  • _config.yml (update devscalaversion or scalaversion)
  • index.md (update currentScalaVersion)
  • Scala 2.13.5 is here scala-lang#1213
• Prepare PR to https://github.com/scala/docs.scala-lang/
  • api/all.md, _config.yml
  • Scala 2.13.5 is here docs.scala-lang#1929
• make sure the draft release notes are on GitHub tag: https://github.com/scala/scala/releases/tag/v2.13.5
• Pre-announce the release on https://contributors.scala-lang.org/c/announcements
• On 2.13.0 only: (manually) update the current symlink for the API docs
  • https://github.com/scala/scala-dist/blob/2.13.x/scripts/jobs/release/website/update-api#L15
• Check that the API docs are published
  • http://www.scala-lang.org/api/2.13.5/
  • https://docs.scala-lang.org/api/all.html ?
  • if they don't show up, possible troubleshooting steps include:
    • review the two scala-dist job logs to make sure that
      • the first one appears to have succeeded putting files in /home/linuxsoft/archives/scala/api on chara.epfl.ch
      • the second one appears to have succeeded in updating the symlink (from 2.1x.y to $SCALA_VER)
    • ssh to chara.epfl.ch and poke around to see if things are where they should be
      • if you don't have the credential for this locally but you are able to bring jenkins-worker-publish up at ssh jenkins-worker-publish, then from there you can ssh -i ~/.ssh/jenkins_lightbend_chara scalatest@chara.epfl.ch
    • see if https://scala-webapps.epfl.ch/jenkins/view/All/job/production_scala-lang.org-scala-dist-archive-sync/ has run a job yet to sync the changes into production
      • if not, you can manually trigger a job. Seth has access to do that, probably others on the team do too. if we get stuck, Fabien can help
• Merge the scala-lang PR and the docs.scala-lang.org PR
  • wait for them to arrive on the websites and make sure they look okay
    • if the scala-lang changes don't show up, possible troubleshooting steps include:
      • see if https://scala-webapps.epfl.ch/jenkins/view/All/job/production_scala-lang.org-builder/ has run a job yet to actually publish the changes
      • see note above about permissions to trigger a job

Modules

• build and release scala-collection-compat and other modules (or open tickets asking that the maintainers do so)
  • this work has moved to https://github.com/scala/make-release-notes/blob/2.13.x/projects-2.13.md
• if it's a 2.12.x release, publish macro paradise for the new version

Announcements

• Scala Users discourse https://users.scala-lang.org
  • https://users.scala-lang.org/t/scala-2-13-5-is-here/7156
• add a reply on the same https://contributors.scala-lang.org thread where you announced that the release process was starting
• Tweet from @scala_lang
  • https://twitter.com/scala_lang/status/1363995761403441160
• https://gitter.im/scala/scala
  • if you feel like it, say something in https://gitter.im/scala/contributors too
• ask Seth to announce on #scala IRC

Afterwards

• Check the release on maven search (may take a few hours):
  • https://search.maven.org/#search%7Cga%7C1%7Cg%3Aorg.scala-lang%20v%3A2.13.5
• Create PR to add/update spec links on scala-lang.org (example: update spec links and advisements scala-lang#1050)
• Create a scala/scala PR to:
  • update starr.version in /versions.properties
  • update Global / baseVersion in /build.sbt
  • update mimaReferenceVersion in /project/MimaFilters.scala
  • clear out mimaFilters in /project/MimaFilters.scala, except the one(s) labeled "KEEP"
  • spec/_config.yml, if it's a major bump
  • 2.13.6 is next; re-STARR on 2.13.5 scala#9517
• If it's a major bump:
  • Update latestSpecVersion in spec/_config.yml on the old branch, so that spec is marked as no longer current
  • Ditto for the nightly build and spec links in _data/footer.yml and _data/doc-nav-header.yml on docs.scala-lang.org
• Create PR to update https://github.com/lightbend/lightbend-technology-intro-doc/blob/master/docs/modules/getting-help/pages/build-dependencies.adoc
• Consider updating https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html
• (Lightbend) Publish scala-fortify-plugin
• (Lightbend) Update WhiteSource
• (Lightbend) Notify eng-updates
• Close this ticket and close the scala-dev milestone

[SethTisue]

hmm, https://travis-ci.com/github/scala/scala/jobs/485066042 has

[error] java.io.FileNotFoundException: /home/travis/.sbt/gpg/secring.asc (No such file or directory)
[error] 	at java.io.FileInputStream.open0(Native Method)
[error] 	at java.io.FileInputStream.open(FileInputStream.java:195)
[error] 	at java.io.FileInputStream.<init>(FileInputStream.java:138)
[error] 	at com.jsuereth.pgp.StreamingLoadable.loadFromFile(StreamingLoadable.scala:11)
[error] 	at com.jsuereth.pgp.StreamingLoadable.loadFromFile$(StreamingLoadable.scala:11)
[error] 	at com.jsuereth.pgp.SecretKeyRing$.loadFromFile(SecretKeyRing.scala:45)
[error] 	at com.jsuereth.pgp.PGP$.loadSecretKeyRing(package.scala:31)

not sure why. I wonder if we ought to bite the bullet and upgrade to sbt-pgp 2.x

[lrytz]

rings a bell, but i'm not sure which one right now...

[SethTisue]

I was tempted to push through an upgrade to sbt-pgp 2 rather than attempt to fix it with the existing versions, but probably it's better to at least try to do the minimum possible fix, first, and only consider an sbt-pgp upgrade as a last resort.

[SethTisue]

My thinking had been, well we moved to travis-ci.com so maybe that means there's a newer GPG on the hosts. But sbt-pgp 1 uses BouncyCastle, so it shouldn't matter.

[SethTisue]

Next thing to try, I guess, is just regenerating the secrets.

[SethTisue]

The secrets were added by Adriaan in scala/scala#6390 in 2018, specifically in 41e376a (#6390), and haven't been touched since

[SethTisue]

Lukas noticed that scala/scala#7432 added dist: bionic to .travis.yml, so that looks like the culprit

[SethTisue]

for debugging admin/init.sh, something like scala/scala@708367b may be useful

see #756

[SethTisue]

in the interest of getting the release out, I removed dist: bionic from .travis.yml and triggered a Travis job on that: https://travis-ci.com/github/scala/scala/jobs/485158674

later at our leisure we can figure out what to do going forward: #764

[SethTisue]

in the interest of getting the release out, I removed dist: bionic from .travis.yml and triggered a Travis job on that: travis-ci.com/github/scala/scala/jobs/485158674

that did work, but I dropped the staging repos since scala/scala#9516 seems like a better idea (thanks @dwijnand for the suggestion)