Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added the missing paragraphs in taste-methods.md english version #2720

Closed
wants to merge 1 commit into from

Conversation

Dedelweiss
Copy link
Contributor

In this PR I have added the paragraphs missing in the English version but not in the Chinese version.

Fixes: #2680

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Dedelweiss although I don't think this is really what we want. Looking at the issue they do seem to be out of sync, but what you have here is already covered on this page as far as I can tell. So I'd say let's close this pr for now and we can discuss on the issue if necessary about if we need to sync the pages or not.

@ckipp01 ckipp01 closed this Mar 10, 2023
@Dedelweiss Dedelweiss deleted the paragraphs_missed branch March 11, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

two or three paragraphs seem missed in _overviews/scala3-book/taste-methods.md
2 participants