IterableOnce#copyToArray uses helper for count [ci: last-only] #10691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
changed the title
SethTisue
added
the
library:collections
He-Pin
reviewed
Mar 2, 2024
| @@ -1035,7 +1037,11 @@ trait IterableOnceOps[+A, +CC[_], +C] extends Any { this: IterableOnce[A] => | |||
| def copyToArray[B >: A](xs: Array[B], start: Int, len: Int): Int = { | |||
There was a problem hiding this comment.
Better update the scala doc for the new behavior.
There was a problem hiding this comment.
I think we'll need a global documentation of out-of-bounds behaviors, as requested in the linked tickets.
This change satisfies the documented behavior, but we need a phrase like "all methods in this package throw on null input", as we read in Javadoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't throw (index out of bounds) when there is no runtime work (destination is zero length or count <= 0).
Audited implementations but did not boost the test coverage much.
Fixes scala/bug#12948