Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Truffle patches #693

Merged
merged 4 commits into from Feb 15, 2022
Merged

Remove Truffle patches #693

merged 4 commits into from Feb 15, 2022

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Feb 15, 2022

These were added to the plugin to support truffle users who were not on the latest Truffle version required to support some logic here. (Long ago)

#692

It's really the end of the road for truffle here - the plugin can no longer access ganache internals the way it needs to with ganache v7. Errors with:

UnhandledRejections detected
Promise {
  <rejected> TypeError: Cannot read private member from an object whose class did not declare it
      at __classPrivateFieldGet (/home/circleci/project/metacoin/node_modules/ganache/dist/node/webpack:/Ganache/core/lib/src/server.js:10:94)
      at close (/home/circleci/project/metacoin/node_modules/ganache/dist/node/webpack:/Ganache/core/lib/src/server.js:221:13)
      at /home/circleci/project/metacoin/node_modules/solidity-coverage/node_modules/pify/index.js:32:6

@cgewecke cgewecke merged commit c69c11c into master Feb 15, 2022
@cgewecke cgewecke deleted the remove-2019-things branch February 15, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant