New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new hook and make temporary contracts directory configurable #664
Conversation
update to latest upstream version
Update master with upstream
#3) * Added onPreCompile hook * Added configurable temporary contracts directory * Added test for new onPreCompile hook * Updated documentation
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
=======================================
Coverage 98.68% 98.69%
=======================================
Files 22 22
Lines 991 993 +2
=======================================
+ Hits 978 980 +2
Misses 13 13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks so much!
Would it be possible to add docs for the hook and the new temp contracts directory option to the config options table in the
- README.md
- HARDHAT_README.md
A brief sentence about how the preCompile hook is useful would also be nice.
(That table is a bit painful to add to in markdown, sorry about this...)
Co-authored-by: cgewecke <christophergewecke@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thanks again.
(Will hopefully publish this weekend)
Hi @cgewecke, just wanted to follow up - I could be missing it but I don't see any new releases containing this work (yet)? |
Hi! I'm so sorry. I thought I had published this, thanks for the ping. I'need to add some tests for #667 tomorrow and will merge and publish then. |
Awesome :) Thanks!! |
This is now published in |
Awesome! |
This PR adds two small features:
I have made an attempt to update the documentation and added the hook to the existing test - please let me know if I can add anything else to make the PR more complete.