Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not release internal modules #1838

Open
1 task
nulls opened this issue Nov 30, 2023 · 1 comment
Open
1 task

Do not release internal modules #1838

nulls opened this issue Nov 30, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request infrastructure Issues related to building the project, CI/CD, deployments etc. plugins Plugins for build systems to allow them to run diktat
Milestone
2.1.0

Comments

@nulls
Copy link
Member

nulls commented Nov 30, 2023

Diktat has two internal modules: diktat-ksp-dev and diktat-common-test. They are not needed in maven central
Also, diktat builds gradle plugin, rulesset for ktlint and cli as fat jar. We can publish only them without internal apis which are not needed anyone in maven central.

TODO:

  • publish maven plugin as a fat jar
@nulls nulls added enhancement New feature or request dependencies Pull requests that update a dependency file plugins Plugins for build systems to allow them to run diktat infrastructure Issues related to building the project, CI/CD, deployments etc. labels Nov 30, 2023
@nulls nulls added this to the 2.1.0 milestone Nov 30, 2023
@nulls
Copy link
Member Author

nulls commented Dec 13, 2023 •
edited

We release fat jar with diktat cli to maven central.
Probably it's not required, we have GitHub releases where we attach it as an asset. Also we attach script for Windows there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request infrastructure Issues related to building the project, CI/CD, deployments etc. plugins Plugins for build systems to allow them to run diktat
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@nulls