Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FILE_NAME_INCORRECT] suggestion for improvement #1747

Open
Cheshiriks opened this issue Sep 22, 2023 · 3 comments
Open

[FILE_NAME_INCORRECT] suggestion for improvement #1747

Cheshiriks opened this issue Sep 22, 2023 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Cheshiriks
Copy link
Member

If the file contains only one Interface or enum class, then it will not have a .kt in the name.
Maybe add this to the rule?
@Cheshiriks Cheshiriks added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Sep 22, 2023
@nulls
Copy link
Member

nulls commented Sep 22, 2023

can you please provide example? I didn't get...

@Cheshiriks
Copy link
Member Author

@nulls I am receiving this message in my save cloud
Снимок

@nulls
Copy link
Member

nulls commented Sep 22, 2023

It's another issue: it's about prefix I. We do not support it and diktat tries to change it to IbaseMetrics.
So need to add two suppressions: @file:Suppress("FILE_NAME_INCORRECT") and @Suppress("CLASS_NAME_INCORRECT")

But probably we should support prefix I which is the common (but from C# world) prefix for interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nulls @Cheshiriks