Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-plugin: treat SarifReportMergeTask as non-mandatory #1487

Merged
merged 2 commits into from Jul 29, 2022

Conversation

petertrr
Copy link
Member

What's done:

  • Root project might not have a task mergeDiktatReports

This pull request closes #1484

### What's done:
* Root project might not have a task `mergeDiktatReports`
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1487 (6f90fb9) into master (4766835) will not change coverage.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master    #1487   +/-   ##
=========================================
  Coverage     82.96%   82.96%           
  Complexity     2579     2579           
=========================================
  Files           111      111           
  Lines          7712     7712           
  Branches       2114     2114           
=========================================
  Hits           6398     6398           
  Misses          418      418           
  Partials        896      896           
Flag Coverage Δ
unittests 82.96% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...diktat/plugin/gradle/tasks/SarifReportMergeTask.kt 18.91% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4766835...6f90fb9. Read the comment docs.

@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 317 tests   1 302 ✔️  1m 22s ⏱️
   161 suites       15 💤
   161 files           0

Results for commit bbd05b7.

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 332 tests   1 317 ✔️  3m 14s ⏱️
   162 suites       15 💤
   162 files           0

Results for commit bbd05b7.

@petertrr petertrr enabled auto-merge (squash) July 29, 2022 16:51
@petertrr petertrr merged commit 2d75446 into master Jul 29, 2022
@petertrr petertrr deleted the bugfix/merge-sarif-pt-2#1484 branch July 29, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle plug-in no longer works w/o the :mergeDiktatReports task
3 participants