fix: prevent unhandled promise rejection that caused action to exit and retries not to happen #60
+98
−1,293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which may happen if it already terminated fixes saucelabs#59
previously if an error happened in the promise constructor it would never be handled anywhere. The promise constructor does not really expect a function that returns a promise, and if it did that rejection would not be handled, as was the case here
because we were seeing timeouts
tjenkinson
changed the title
tjenkinson
added a commit
to video-dev/hls.js
that referenced
this pull request
Nov 19, 2022
waggledans
reviewed
Dec 22, 2022
waggledans
approved these changes
Dec 22, 2022
|
Thanks for merging! Looks like the build needs updating in the main branch though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if an error happened in the promise constructor in
startSc(like the error that is rethrown as the result of a timeout) it would never be handled anywhere, causing node to exit with an error as a result of an unhandled promise rejection. The promise constructor does not really expect a function that returns a promise, and if it did that rejection would not be handled, as was the case here.So this PR updates
scartScto not be wrapped in anew Promise.It also increases the timeout as I saw 45 seconds was sometimes not enough.
fixes #59