Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2022-25758 Vulnerability #48

Closed
curtvict opened this issue Jul 12, 2022 · 9 comments · Fixed by #49
Closed

CVE-2022-25758 Vulnerability #48

curtvict opened this issue Jul 12, 2022 · 9 comments · Fixed by #49

Comments

@curtvict
Copy link

I'm getting a Dependabot warning in my project for this package: GHSA-7mwh-4pqv-wmr8

This previously opened issue also seems related: #45

@amharris1331
Copy link

I'm also seeing this issue and there is no guidance on how to fix this vulnerability.

@melMass
Copy link

melMass commented Jul 19, 2022

I'm also seeing this issue and there is no guidance on how to fix this vulnerability.

Because the solution should be fixed upstream, i.e here.

Is there an ETA to merge either this or #49 ? cc @xzyfer

@dolanite
Copy link

if scss-tokenizer is a dependency of sass-loader, as it was in my lib

sass-loader@12.6.0

node-sass@7.0.1

node-gyp@8.4.1

sass-graph@4.0.0

scss-tokenizer@0.3.0

then updating sass-loader@12.6.0 to sass-loader@13.0.2
resolves this issue

In sass-loader@13.0.2 node-sass is an optional dependency
node-sass is deprecated, moving to Dart Sass is recommended

@rbitting
Copy link

Updating from node-sass to sass as recommended by @dolanite resolved the issue for me. Thanks!

@Flyingliuhub
Copy link

Flyingliuhub commented Aug 1, 2022

@rbitting , are you updating from node-sass to sass or dark sass? I'm confused here.

@curtvict
Copy link
Author

curtvict commented Aug 2, 2022

I don't have a lot of skin in the game anymore since, admittedly, after asking this question I realized that node-sass was an unused dependency in my package, but from what I can tell from the sass package README is the Dart implementation of Sass.

@Flyingliuhub
Copy link

Thanks @curtvict

@xzyfer
Copy link
Member

xzyfer commented Aug 10, 2022

Fixed in v0.4.3

@paul-p-rga
Copy link

I'm not sure if this is the right place to bring this up, but https://nvd.nist.gov/vuln/detail/CVE-2022-25758 has never updated the affected versions to indicate < 0.4.3, though snyk has long-since recognized the fix https://security.snyk.io/vuln/SNYK-JS-SCSSTOKENIZER-2339884.

Is there something that the maintainers of the library can do to help get the vulnerability details updated in NIST and other trackers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants