Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failOnError fails without any linting errors #51

Open
brphelps opened this issue Jul 27, 2016 · 1 comment
Open

failOnError fails without any linting errors #51

brphelps opened this issue Jul 27, 2016 · 1 comment
Labels

Comments

@brphelps
Copy link

\node_modules\gulp-sass-lint\index.js:93
if (file.sassLint[0].errorCount > 0) {
^

TypeError: Cannot read property '0' of undefined
at DestroyableTransform._transform (\node_modules\gulp-sass-lint\index.js:93:22)

running latest on sass-lint and gulp-sass-lint.

@brphelps brphelps changed the title failOnError fails without an error failOnError fails without any linting errors Jul 27, 2016
@brphelps
Copy link
Author

Some more context on this -- This happens when individual files were excluded from an earlier sass-lint pass, but still end up flowing through the pipe to .failOnError(). It seems like it would be pretty easy to either (a) 'skip' files if you don't see a .sassLint tracking property on them, or (b) throw a more meaningful error that would explain the cause of the issue to callers. I personally would lean towards (a) as I don't think there's a good reason for consumers to have to be aware of how gulp-sass-lint captures these details internally.

@brphelps brphelps added the bug label Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant