Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"target" should be "src" #23

Open
mischkl opened this issue May 2, 2016 · 4 comments
Open

"target" should be "src" #23

mischkl opened this issue May 2, 2016 · 4 comments

Comments

@mischkl
Copy link

mischkl commented May 2, 2016

Usually the "target" property is used when there are output files, and the "src" property for specifying input files. Admittedly it makes little practical difference, but it's definitely confusing and going against pretty much every other grunt plugin out there that you need to specify "target" to use this plugin and not "src".

@vlad-saling
Copy link

@mischkl Interesting. That actually helped me get grunt-sass-lint working. I was using example config with "target" keyword an sass-lint wasn't picking up files. When I switch to "src" it suddenly started working. Could it be possible the author already implemented this? Though I could not (quickly) find respective commit.

@mischkl
Copy link
Author

mischkl commented Aug 23, 2016

Hmm, I'm also not sure if/when it was fixed or if I added the issue before testing it out. In any case at the current point in time it seems to be an error in the documentation, not the implementation.

@vlad-saling
Copy link

I'll test again and if I confirm this within another environment (aka clean machine) I'll make a PR to update documentation/example config.

@vlad-saling
Copy link

Update: On Windows 10 this plugin works both with "src" and "target" while on OSX it works only with "src" for me. I won't be doing a PR just know since I don't really understand what's happening :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants