Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libsass to 3.6.4 #199

Merged
merged 1 commit into from Jun 2, 2020
Merged

Update libsass to 3.6.4 #199

merged 1 commit into from Jun 2, 2020

Conversation

ahorek
Copy link

@ahorek ahorek commented May 1, 2020

uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request May 17, 2020
This is a workaround for gitlab-ce. It should be fixed after rubygem-sassc
updating libsass from 3.6.3 to 3.6.4.

Reference:	https://gitlab.com/gitlab-org/gitlab/-/issues/216740
		sass/sassc-ruby#201
		sass/sassc-ruby#199


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@535562 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request May 17, 2020
- Bump PORTREVISION for dependency change

This is a workaround for gitlab-ce. It should be fixed after rubygem-sassc
updating libsass from 3.6.3 to 3.6.4.

Reference:	https://gitlab.com/gitlab-org/gitlab/-/issues/216740
		sass/sassc-ruby#201
		sass/sassc-ruby#199


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@535563 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request May 17, 2020
This is a workaround for gitlab-ce. It should be fixed after rubygem-sassc
updating libsass from 3.6.3 to 3.6.4.

Reference:	https://gitlab.com/gitlab-org/gitlab/-/issues/216740
		sass/sassc-ruby#201
		sass/sassc-ruby#199
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request May 17, 2020
- Bump PORTREVISION for dependency change

This is a workaround for gitlab-ce. It should be fixed after rubygem-sassc
updating libsass from 3.6.3 to 3.6.4.

Reference:	https://gitlab.com/gitlab-org/gitlab/-/issues/216740
		sass/sassc-ruby#201
		sass/sassc-ruby#199
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request May 18, 2020
This is a workaround for gitlab-ce. It should be fixed after rubygem-sassc
updating libsass from 3.6.3 to 3.6.4.

Reference:	https://gitlab.com/gitlab-org/gitlab/-/issues/216740
		sass/sassc-ruby#201
		sass/sassc-ruby#199


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@535562 35697150-7ecd-e111-bb59-0022644237b5
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request May 18, 2020
- Bump PORTREVISION for dependency change

This is a workaround for gitlab-ce. It should be fixed after rubygem-sassc
updating libsass from 3.6.3 to 3.6.4.

Reference:	https://gitlab.com/gitlab-org/gitlab/-/issues/216740
		sass/sassc-ruby#201
		sass/sassc-ruby#199


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@535563 35697150-7ecd-e111-bb59-0022644237b5
@toncid
Copy link

toncid commented May 20, 2020

This is a straightforward change. Any chances of pushing this update?

@lxxxvi
Copy link

lxxxvi commented May 29, 2020

Hello, I don't know much about libsass and and/or this gem, but I encountered a problem in one of my projects (Rails) with sassc version v2.3.0.

The problem appears in the rake task assets:precompile where sassc is called (I guess).
On Mac OS X (10.15.4, Catalina) the process runs forever for no apparent reason and has to be killed manually. On CI (Ubuntu 16.04) I actually get an error

*** Error in `ruby': corrupted size vs. prev_size: 0x0000000006d44810 ***
======= Backtrace: =========

/lib/x86_64-linux-gnu/libc.so.6(+0x777e5)[0x7fbd888c17e5]

/lib/x86_64-linux-gnu/libc.so.6(+0x7e9dc)[0x7fbd888c89dc]

/lib/x86_64-linux-gnu/libc.so.6(+0x81cde)[0x7fbd888cbcde]

/lib/x86_64-linux-gnu/libc.so.6(__libc_malloc+0x54)[0x7fbd888ce184]

/usr/lib/x86_64-linux-gnu/libstdc++.so.6(_Znwm+0x18)[0x7fbd7700be78]

/home/travis/build/[user]/[project]vendor/bundle/ruby/2.6.0/bundler/gems/sassc-ruby-1bc1c545f38a/lib/sassc
#  DO YOU NEED MORE ?

...including a "Backtrace" and "Memory map" (I am not sure if it's relevant to post the full output here).

After some desperate experiments, I found that libsass 3.6.4 addressed an issue that caused a "massive memory leak", so I installed this branch from @ahorek and then the rake task worked again.

May be worth mentioning is that I spotted the problem when running rails test and the process didn't seem to start since the assets:precompilation got stuck in the "memory"-problem.

Also: In the project I use Foundation CSS framework, which could be a trigger for the problem.

In conclusion: I am looking forward to seeing a new version of this gem ;-)

@bolandrm bolandrm merged commit 9256d01 into sass:master Jun 2, 2020
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 7, 2020
Update ruby-sassc to 2.4.0.


**2.4.0**
  - [Update libsass to 3.6.4](sass/sassc-ruby#199)
  - [Use FFI::MemoryPointer instead of libc's malloc()](sass/sassc-ruby#205)
  - [Test against Ruby 2.7.0](sass/sassc-ruby#193)
stanhu added a commit to stanhu/sassc-ruby that referenced this pull request Aug 24, 2020
libsass was updated to v3.6.4 in sassc-ruby v2.4.0 via sass#199.
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this pull request Jan 10, 2024
This is a workaround for gitlab-ce. It should be fixed after rubygem-sassc
updating libsass from 3.6.3 to 3.6.4.

Reference:	https://gitlab.com/gitlab-org/gitlab/-/issues/216740
		sass/sassc-ruby#201
		sass/sassc-ruby#199
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this pull request Jan 10, 2024
- Bump PORTREVISION for dependency change

This is a workaround for gitlab-ce. It should be fixed after rubygem-sassc
updating libsass from 3.6.3 to 3.6.4.

Reference:	https://gitlab.com/gitlab-org/gitlab/-/issues/216740
		sass/sassc-ruby#201
		sass/sassc-ruby#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid CSS generated with 2.3.0 (Nesting + child combinator + selector lists + interpolation)
4 participants