Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove meta.feature-exists() #3702

Open
nex3 opened this issue Sep 27, 2023 · 3 comments
Open

Deprecate and remove meta.feature-exists() #3702

nex3 opened this issue Sep 27, 2023 · 3 comments
Labels
enhancement New feature or request requires deprecation Blocked on a deprecation cycle

Comments

@nex3
Copy link
Contributor

nex3 commented Sep 27, 2023

From sass/sass-spec#1939 (comment):

In practice, essentially all the new features we add fall into one of three categories:

  1. New built-in functions or mixins, which are easy to detect using other sass:meta functions.
  2. Language-level features which are relatively easy to detect on their own (for example, first-class calc can be detected with calc(1 + 1) == 2).
  3. New syntax which can't even be parsed in implementations that don't support it, for which feature detection isn't particularly useful anyway.

This, combined with the fact that we haven't added a new feature to meta.feature-exists() in years, suggests that it's not useful anymore and should be removed.

@nex3 nex3 added the requires deprecation Blocked on a deprecation cycle label Sep 27, 2023
@nex3 nex3 changed the title Deprecate meta.feature-exists() Deprecate and remove meta.feature-exists() Sep 27, 2023
@nex3 nex3 added the enhancement New feature or request label Oct 9, 2023
@nex3
Copy link
Contributor Author

nex3 commented Jan 16, 2024

#3749 has landed and the proposal is out for review. Since it's a breaking change, I'll give it a month for public comment before we can mark it as accepted and implement.

@nex3
Copy link
Contributor Author

nex3 commented May 7, 2024

@stof We just released 1.77.0, so these will need to be 1.78.0.

@stof
Copy link
Contributor

stof commented May 7, 2024

@nex3 I updated all PRs to mention 1.78.0, and I also opened the missing PR for the website to document the deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requires deprecation Blocked on a deprecation cycle
Projects
None yet
Development

No branches or pull requests

2 participants