Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all <angle> units in color functions #2904

Open
8 of 11 tasks
nex3 opened this issue Sep 16, 2020 · 2 comments
Open
8 of 11 tasks

Support all <angle> units in color functions #2904

nex3 opened this issue Sep 16, 2020 · 2 comments
Labels
CSS compatibility Support the CSS spec enhancement New feature or request planned We would like to add this feature at some point requires deprecation Blocked on a deprecation cycle

Comments

@nex3
Copy link
Contributor

nex3 commented Sep 16, 2020 •
edited

Phase 1

Phase 2

Phase 3

Currently, Sass's color functions (including both the existing functions and the functions added by #2835) only support deg as a hue unit. CSS specifies, and browsers support, a wider variety of units, including grad, rad, and turn. We should support all these units, internally converting them to deg.

Because hsl()'s and *-color()'s $hue arguments currently accept any unit, not just a unitless number or deg, this will require an intermediate deprecation step where we forbid units other than deg for hue values. As part of this, we can also tighten up the unit requirements for $saturation and $lightness to require either no unit or %.
@nex3 nex3 added enhancement New feature or request CSS compatibility Support the CSS spec planned We would like to add this feature at some point requires deprecation Blocked on a deprecation cycle labels Sep 16, 2020
@nex3 nex3 mentioned this issue Sep 16, 2020
Merged
@nex3 nex3 mentioned this issue Nov 17, 2020
Merged
nex3 added a commit that referenced this issue Nov 17, 2020
@nex3
Add some basic spec text for units
32b13cc 
This lays some groundwork that will be useful for #2904.
nex3 added a commit that referenced this issue Nov 17, 2020
@nex3
Add some basic spec text for units (#2951)
d0d24a9 
This lays some groundwork that will be useful for #2904.

Co-authored-by: Awjin Ahn <awjin@google.com>
@nex3 nex3 mentioned this issue Nov 17, 2020
Merged
nex3 added a commit that referenced this issue Nov 17, 2020
@nex3
[Angle Units] Create proposal
e5d8f2e 
See #2904
nex3 added a commit that referenced this issue Nov 18, 2020
@nex3
[Angle Units] Create proposal (#2953)
f1b9f9f 
See #2904
@nex3
Copy link
Contributor Author

nex3 commented Nov 18, 2020

The proposal has landed, giving it two weeks for public comment.

nex3 added a commit that referenced this issue Dec 17, 2020
@nex3
[Angle Units] Mark the proposal as accepted
ca3326f 
See #2904
@nex3 nex3 mentioned this issue Dec 17, 2020
Merged
nex3 added a commit that referenced this issue Dec 17, 2020
@nex3
[Angle Units] Mark the proposal as accepted
e6a9638 
See #2904
nex3 added a commit that referenced this issue Dec 18, 2020
@nex3
[Angle Units] Mark the proposal as accepted
7d7f340 
See #2904
nex3 added a commit that referenced this issue Dec 18, 2020
@nex3
[Angle Units] Mark the proposal as accepted
9f67360 
See #2904
nex3 added a commit that referenced this issue Dec 21, 2020
@nex3
[Angle Units] Mark the proposal as accepted (#2974)
150d805 
See #2904
This was referenced Dec 29, 2020
Open
Open
Open
Merged
Merged
nex3 added a commit to sass/sass-site that referenced this issue Dec 29, 2020
@nex3
Document new color unit behavior
90373dd 
Partially addresses #511
See sass/sass#2904
@nex3 nex3 mentioned this issue Dec 29, 2020
Merged
nex3 added a commit to sass/sass-site that referenced this issue Dec 29, 2020
@nex3
Document new color unit behavior (#512)
b7aa7b4 
Partially addresses #511
See sass/sass#2904
mirisuzanne pushed a commit that referenced this issue Feb 10, 2022
@nex3 @mirisuzanne
Add some basic spec text for units (#2951)
b97c5f4 
This lays some groundwork that will be useful for #2904.

Co-authored-by: Awjin Ahn <awjin@google.com>
mirisuzanne pushed a commit that referenced this issue Feb 10, 2022
@nex3 @mirisuzanne
[Angle Units] Create proposal (#2953)
a4def21 
See #2904
mirisuzanne pushed a commit that referenced this issue Feb 10, 2022
@nex3 @mirisuzanne
[Angle Units] Mark the proposal as accepted (#2974)
e6dad12 
See #2904
@nex3 nex3 mentioned this issue Oct 28, 2022
Merged
nex3 added a commit to sass/sass-spec that referenced this issue Oct 28, 2022
@nex3
Update specs to convert angle units to deg
d15e990 
See #1607
See sass/sass#2904
@nex3 nex3 mentioned this issue Oct 28, 2022
Merged
nex3 added a commit to sass/dart-sass that referenced this issue Oct 28, 2022
@nex3
Support all angle units in color functions
e83d8c1 
See #1174
See sass/sass#2904
@nex3 nex3 mentioned this issue Oct 28, 2022
Merged
nex3 added a commit to sass/sass-site that referenced this issue Oct 28, 2022
@nex3
Add/update strict function unit documentation
68ca5d0 
This merges the color-units and random-with-units deprecation pages
into a single shared function-units page, updates the color-units
deprecations to reflect that Phase 2 has been enacted, and adds new
function unit deprecations.

See #511
See sass/sass#2904
See #662
See sass/sass#3374
nex3 added a commit to sass/sass-spec that referenced this issue Oct 28, 2022
@nex3
Update specs to convert angle units to deg
bfb1fba 
See #1607
See sass/sass#2904
nex3 added a commit to sass/dart-sass that referenced this issue Oct 28, 2022
@nex3
Support all angle units in color functions
71f9069 
See #1174
See sass/sass#2904
nex3 added a commit to sass/sass-site that referenced this issue Oct 28, 2022
@nex3
Add/update strict function unit documentation
ca6ffcb 
This merges the color-units and random-with-units deprecation pages
into a single shared function-units page, updates the color-units
deprecations to reflect that Phase 2 has been enacted, and adds new
function unit deprecations.

See #511
See sass/sass#2904
See #662
See sass/sass#3374
nex3 added a commit to sass/sass-spec that referenced this issue Oct 28, 2022
@nex3
Update specs to convert angle units to deg (#1831)
b682f8e 
See #1607
See sass/sass#2904
nex3 added a commit to sass/dart-sass that referenced this issue Oct 28, 2022
@nex3
Support all angle units in color functions (#1818)
558640b 
See #1174
See sass/sass#2904
nex3 added a commit to sass/sass-site that referenced this issue Oct 28, 2022
@nex3
Add/update strict function unit documentation (#683)
f80aa04 
This merges the color-units and random-with-units deprecation pages
into a single shared function-units page, updates the color-units
deprecations to reflect that Phase 2 has been enacted, and adds new
function unit deprecations.

See #511
See sass/sass#2904
See #662
See sass/sass#3374
@nex3
Copy link
Contributor Author

nex3 commented Mar 2, 2023

This is now waiting on Dart Sass 2.0.0

asaf400 pushed a commit to asaf400/ass-site that referenced this issue Apr 18, 2024
Document new color unit behavior (sass#512)
bb8648f 
Partially addresses sass#511
See sass/sass#2904
asaf400 pushed a commit to asaf400/ass-site that referenced this issue Apr 18, 2024
Add/update strict function unit documentation (sass#683)
d9d6fbe 
This merges the color-units and random-with-units deprecation pages
into a single shared function-units page, updates the color-units
deprecations to reflect that Phase 2 has been enacted, and adds new
function unit deprecations.

See sass#511
See sass/sass#2904
See sass#662
See sass/sass#3374
asaf400 pushed a commit to asaf400/ass-site that referenced this issue Apr 18, 2024
Document new color unit behavior (sass#512)
352b20d 
Partially addresses sass#511
See sass/sass#2904
asaf400 pushed a commit to asaf400/ass-site that referenced this issue Apr 18, 2024
Add/update strict function unit documentation (sass#683)
4e4e203 
This merges the color-units and random-with-units deprecation pages
into a single shared function-units page, updates the color-units
deprecations to reflect that Phase 2 has been enacted, and adds new
function unit deprecations.

See sass#511
See sass/sass#2904
See sass#662
See sass/sass#3374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS compatibility Support the CSS spec enhancement New feature or request planned We would like to add this feature at some point requires deprecation Blocked on a deprecation cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nex3