Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for built-in functions #1001

Open
nex3 opened this issue Dec 12, 2016 · 2 comments
Open

Add specs for built-in functions #1001

nex3 opened this issue Dec 12, 2016 · 2 comments
Labels
tests to add

Comments

@nex3
Copy link
Contributor

nex3 commented Dec 12, 2016 •
edited

All the built-in functions need thorough specs that exercise their edge and error cases. There isn't currently a great structure in place for this; some functions have some specs scattered around the repo, but there should be a uniform location and we should make sure all functions are tested.

Ruby Sass has good test coverage for functions, so the best way to go about this is probably porting those. I suggest the following structure:

spec/
'-- core_function/
    |-- color/
    | ...
    '-- number/
        |-- round/
        | ...
        '-- max/
            |-- success/
            |   |-- input.scss
            |   '-- expected_output.scss
            '-- error/
                |-- type_error_arg1/
                |   |-- input.scss
                |   '-- expected_output.scss
                '-- type_error_arg2/
                    |-- input.scss
                    '-- expected_output.scss

For functions with more complex modes of operation, we could replace success/ with multiple test cases.
@nex3
Copy link
Contributor Author

nex3 commented Dec 12, 2016

We should also retrofit the existing spec/colors/, spec/number-functions/, and spec/selector-functions/ into this format.

For the time being, I'm adding this structure lazily when I need to create a spec for a function.

nex3 added a commit that referenced this issue Jul 18, 2018
@nex3
Clean up specs
b63eb44 
This moves the specs to the directories suggested in
#1001, updates them to use get-function(), and documents
the exact issues that they're testing.

It also updates the output of one of them to be an error, which is
expected.
nex3 added a commit that referenced this issue Nov 7, 2018
@nex3
Add full specs for rgb(), hsl(), rgba(), and hsla()
5814a13 
Partially addresses #1001
@nex3 nex3 mentioned this issue Nov 7, 2018
Merged
nex3 added a commit that referenced this issue Nov 12, 2018
@nex3
Add full specs for rgb(), hsl(), rgba(), and hsla() (#1300)
3748290 
Partially addresses #1001
This was referenced May 31, 2019
Merged
Merged
@nex3 nex3 mentioned this issue Feb 28, 2020
Merged
nex3 added a commit that referenced this issue Feb 29, 2020
@nex3
Add specs for selector-nest()
772b41c 
See #1001
@nex3 nex3 mentioned this issue Feb 29, 2020
Merged
nex3 added a commit that referenced this issue Mar 2, 2020
@nex3
Add specs for selector-nest() (#1522)
94d83ec 
See #1001
@nex3 nex3 mentioned this issue Mar 2, 2020
Merged
nex3 added a commit that referenced this issue Mar 4, 2020
@nex3
Add specs for selector-replace()
2c748c1 
See #1001
nex3 added a commit that referenced this issue Mar 4, 2020
@nex3
Add specs for selector-unify()
48308df 
See #1001
@nex3 nex3 mentioned this issue Mar 4, 2020
Merged
nex3 added a commit that referenced this issue Mar 6, 2020
@nex3
Add specs for selector-unify() (#1525)
38e2d4b 
See #1001
@stof
Copy link
Contributor

stof commented Feb 26, 2022

@nex3 Can this be considered done now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests to add
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @stof