From 7fa6ffa45aa91a4d51cde04674e0e7e4adf1c4c0 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Thu, 21 Oct 2021 20:13:00 -0400 Subject: [PATCH 1/2] feat: Add Node 17 support --- .github/workflows/alpine.yml | 3 +++ .github/workflows/linux.yml | 5 +++++ .github/workflows/macos.yml | 1 + .github/workflows/windows.yml | 3 +++ README.md | 1 + appveyor.yml | 3 +++ lib/extensions.js | 1 + package.json | 2 +- 8 files changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index f46d8772e..450e8fef7 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -19,6 +19,7 @@ jobs: - 14 - 15 - 16 + - 17 include: - node: 12 @@ -29,6 +30,8 @@ jobs: python: python3 - node: 16 python: python3 + - node: 17 + python: python3 steps: - name: Install Alpine build tools diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 034f4b05e..83b99bcf5 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -18,6 +18,7 @@ jobs: - 14 - 15 - 16 + - 17 include: - node: 12 @@ -36,6 +37,10 @@ jobs: gcc: "gcc-8" gpp: "g++-8" os: ubuntu-18.04 + - node: 17 + gcc: "gcc-8" + gpp: "g++-8" + os: ubuntu-18.04 steps: diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 7adeb9600..e0f030838 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -18,6 +18,7 @@ jobs: - 14 - 15 - 16 + - 17 steps: - uses: actions/checkout@v2 diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index b3ff60a32..f00fa7885 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -18,6 +18,7 @@ jobs: - 14 - 15 - 16 + - 17 architecture: - x64 @@ -32,6 +33,8 @@ jobs: os: windows-2019 - node: 16 os: windows-2019 + - node: 17 + os: windows-2019 steps: - uses: actions/checkout@v2 diff --git a/README.md b/README.md index 11f080963..620572e58 100644 --- a/README.md +++ b/README.md @@ -17,6 +17,7 @@ Below is a quick guide for minimum and maximum supported versions of node-sass: NodeJS | Supported node-sass version | Node Module --------|-----------------------------|------------ +Node 17 | 6.0+ | 102 Node 16 | 6.0+ | 93 Node 15 | 5.0+ | 88 Node 14 | 4.14+ | 83 diff --git a/appveyor.yml b/appveyor.yml index 97bd89919..aaefbae68 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -45,6 +45,9 @@ - nodejs_version: 16 GYP_MSVS_VERSION: 2019 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 + - nodejs_version: 17 + GYP_MSVS_VERSION: 2019 + APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 install: # https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs diff --git a/lib/extensions.js b/lib/extensions.js index ce4b17a56..8f31450a3 100644 --- a/lib/extensions.js +++ b/lib/extensions.js @@ -81,6 +81,7 @@ function getHumanNodeVersion(abi) { case 83: return 'Node.js 14.x'; case 88: return 'Node.js 15.x'; case 93: return 'Node.js 16.x'; + case 102: return 'Node.js 17.x'; default: return false; } } diff --git a/package.json b/package.json index 163b794ee..f6297a1a8 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "node-sass", - "version": "6.0.1", + "version": "7.0.0", "libsass": "3.5.5", "description": "Wrapper around libsass", "license": "MIT", From 3b35f529b104b19beb2b8851fcacd42ba8f91997 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Thu, 21 Oct 2021 20:43:02 -0400 Subject: [PATCH 2/2] fix: Version range for 17 Co-authored-by: Michael Mifsud --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 620572e58..402db427b 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Below is a quick guide for minimum and maximum supported versions of node-sass: NodeJS | Supported node-sass version | Node Module --------|-----------------------------|------------ -Node 17 | 6.0+ | 102 +Node 17 | 7.0+ | 102 Node 16 | 6.0+ | 93 Node 15 | 5.0+ | 88 Node 14 | 4.14+ | 83