Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability [CVE-2021-3918] #3204

Closed
mertyildiran opened this issue Nov 15, 2021 · 11 comments
Closed

Security vulnerability [CVE-2021-3918] #3204

mertyildiran opened this issue Nov 15, 2021 · 11 comments

Comments

@mertyildiran
Copy link

Dependency tree:
node-sass@5.0.0 > node-gyp@7.1.2 > request@2.88.2 > http-signature@1.2.0 > jsprim@1.4.1 > json-schema@0.2.3

CVE-2021-3918

I guess it's present node-sass@6.0.0 and node-sass@6.0.1 as well.

@arderyp
Copy link

arderyp commented Nov 20, 2021

thanks for the issue.

I believe node-sass directly requires request*^2.88.0

If the aforementioned request package is the same as this (repo), its been deprecated for the better part of a year and should thus be dropped altogether to solve this problem. In an ideal world. I'm not familiar enough with these packages myself to know how easy/feasible this would be.

@pzrq
Copy link
Contributor

pzrq commented Nov 22, 2021

Moving away from request is an option already implemented in node-gyp v8 here - i.e. the clearest success path for node-sass to me looks like upgrading node-gyp from v7 plus any direct usages here in node-sass (as it is also in dependencies at the moment).

However, another option is suggested here too, so it's possible it might get resolved upstream too.

@pzrq
Copy link
Contributor

pzrq commented Nov 22, 2021

It also looks like others would like to move away from requests: #3200

@arderyp
Copy link

arderyp commented Nov 25, 2021

is this project still being actively maintained?

@Delwalt
Copy link

Delwalt commented Nov 29, 2021

Anyone still looking into this issue?

I am also facing the same issue. Latest version of json-schema (0.4.0) is available which has some vulnerability fixes but due to node-sass dependency couldn't upgrade.

@arderyp
Copy link

arderyp commented Nov 30, 2021

is it viable to uninstall node-sass and use sass instead?

@arderyp
Copy link

arderyp commented Dec 1, 2021

for what it's worth, I replaced node-sass with sass, which appears to be more actively maintained, and it "just worked" as a drop in solution:

yarn remove node-sass
yarn add sass
# run your rebuild

@pzrq
Copy link
Contributor

pzrq commented Dec 3, 2021

is it viable to uninstall node-sass and use sass instead?

@arderyp Yes: https://sass-lang.com/documentation/js-api

@arderyp
Copy link

arderyp commented Dec 3, 2021

yup @pzrq, I already took care of it and it was a breeze :)

@xzyfer
Copy link
Contributor

xzyfer commented Dec 27, 2021

Should be resolved when #3209 is released.

@xzyfer
Copy link
Contributor

xzyfer commented Dec 27, 2021

Fixed in 7.0.1.

@xzyfer xzyfer closed this as completed Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants